[PR #754] [MERGED] web/layout: increase toggle contrast in dark mode #1256

Closed
opened 2025-11-09 10:09:12 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/754
Author: @alectrocute
Created: 9/16/2024
Status: Merged
Merged: 10/4/2024
Merged by: @wukko

Base: mainHead: AA/toggle-active-color


📝 Commits (3)

  • 382fa01 Change toggle background color to var(--green) if active
  • 5dd1677 Use correct color variable
  • 686cf5c make suggested improvements per @wukko

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 web/src/routes/+layout.svelte (+1 -1)

📄 Description

  • Use var(--green) as active background color
    • There is currently a good amount of difficulty in determining which toggles are enabled and disabled, especially for the visually impaired. I propose we use an active color with more contrast to the inactive color.
Screenshot 2024-09-16 at 7 38 07 AM Screenshot 2024-09-16 at 7 38 13 AM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/754 **Author:** [@alectrocute](https://github.com/alectrocute) **Created:** 9/16/2024 **Status:** ✅ Merged **Merged:** 10/4/2024 **Merged by:** [@wukko](https://github.com/wukko) **Base:** `main` ← **Head:** `AA/toggle-active-color` --- ### 📝 Commits (3) - [`382fa01`](https://github.com/imputnet/cobalt/commit/382fa01ba18b62f3ec3b045b634944b2c2681f44) Change toggle background color to var(--green) if active - [`5dd1677`](https://github.com/imputnet/cobalt/commit/5dd1677cdc1378dcb423f46f87d72a875cfc95a4) Use correct color variable - [`686cf5c`](https://github.com/imputnet/cobalt/commit/686cf5cc3ea0ce04e2a686bca32befab25bedf45) make suggested improvements per @wukko ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `web/src/routes/+layout.svelte` (+1 -1) </details> ### 📄 Description - Use `var(--green)` as active background color - There is currently a good amount of difficulty in determining which toggles are enabled and disabled, especially for the visually impaired. I propose we use an active color with more contrast to the inactive color. <img width="614" alt="Screenshot 2024-09-16 at 7 38 07 AM" src="https://github.com/user-attachments/assets/2bd77e78-75bc-4eec-bf3f-478e43cb6d26"> <img width="604" alt="Screenshot 2024-09-16 at 7 38 13 AM" src="https://github.com/user-attachments/assets/eb820d9e-3d12-429c-9640-7d5b43194b0e"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-09 10:09:12 -06:00
Sign in to join this conversation.