[PR #682] [CLOSED] feat: newgrounds video & audio support #1238

New Issue

GiteaMirror · 2025-11-09T10:08:48-06:00

GiteaMirror commented

2025-11-09 10:08:48 -06:00

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/682
Author: @hyperdefined
Created: 8/8/2024
Status: ❌ Closed

Base: main ← Head: newgrounds-support

📝 Commits (4)

f582d1b feat: newgrounds video & audio support
219b5f7 newgrounds: return proper error codes
7b77691 api/test: migrate newgrounds tests
2ffa889 newgrounds: remove unused utils function

📊 Changes

7 files changed (+221 additions, -1 deletions)

View changed files

📝 api/README.md (+1 -0)
📝 api/src/processing/match-action.js (+1 -0)
📝 api/src/processing/match.js (+12 -0)
📝 api/src/processing/service-config.js (+3 -0)
📝 api/src/processing/service-patterns.js (+6 -1)
➕ api/src/processing/services/newgrounds.js (+156 -0)
➕ api/src/util/tests/newgrounds.json (+42 -0)

📄 Description

a cleaner version of my previous pull request, no ugly history this time.

adds support for newgrounds video & music.

example links:

https://www.newgrounds.com/portal/view/938050 - video
https://www.newgrounds.com/audio/listen/500476 - music

~~videos are returned as the highest quality available. support for picking the resolution could be added easily, since newgrounds stores multiple resolutions.~~

this pull request would close #620 (except for art, but I don't see a reason for it being added here).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/682 **Author:** [@hyperdefined](https://github.com/hyperdefined) **Created:** 8/8/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `newgrounds-support` --- ### 📝 Commits (4) - [`f582d1b`](https://github.com/imputnet/cobalt/commit/f582d1b2ce90bb5e25802fde2410312c43bd2cc4) feat: newgrounds video & audio support - [`219b5f7`](https://github.com/imputnet/cobalt/commit/219b5f732f8945c786ec24dae0587beee5521932) newgrounds: return proper error codes - [`7b77691`](https://github.com/imputnet/cobalt/commit/7b776910e8283cf1011e6d37bf11349f00439333) api/test: migrate newgrounds tests - [`2ffa889`](https://github.com/imputnet/cobalt/commit/2ffa889f2441f65850108c6ad39463109c864635) newgrounds: remove unused utils function ### 📊 Changes **7 files changed** (+221 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `api/README.md` (+1 -0) 📝 `api/src/processing/match-action.js` (+1 -0) 📝 `api/src/processing/match.js` (+12 -0) 📝 `api/src/processing/service-config.js` (+3 -0) 📝 `api/src/processing/service-patterns.js` (+6 -1) ➕ `api/src/processing/services/newgrounds.js` (+156 -0) ➕ `api/src/util/tests/newgrounds.json` (+42 -0) </details> ### 📄 Description a cleaner version of my previous pull request, no ugly history this time. adds support for newgrounds video & music. example links: * https://www.newgrounds.com/portal/view/938050 - video * https://www.newgrounds.com/audio/listen/500476 - music ~~videos are returned as the highest quality available. support for picking the resolution could be added easily, since newgrounds stores multiple resolutions.~~ this pull request would close #620 (except for art, but I don't see a reason for it being added here). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-09 10:08:48 -06:00

GiteaMirror closed this issue

2025-11-09 10:08:48 -06:00

GiteaMirror referenced this issue

2025-11-09 10:11:18 -06:00

[PR #1238] [MERGED] api/service-patterns: increase xiaohongshu shareId max length #1355

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cobalt#1238