github-starred/cobalt
2
0
Fork 0
mirror of https://github.com/imputnet/cobalt.git synced 2026-03-09 07:17:16 -05:00
Code Issues 202 Packages Projects Releases Wiki Activity

[PR #639] [CLOSED] feat: newgrounds support #1229

New Issue
Closed
opened 2025-11-09 10:08:36 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-09 10:08:36 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/639
Author: @hyperdefined
Created: 7/18/2024
Status: ❌ Closed

Base: current ← Head: newgrounds-support

📝 Commits (10+)

  • 5efe510 initial newgrounds support
  • 5723239 added video parsing
  • b219c3e error checking for parsing things
  • 488ea8b undo these testing things
  • 27a1d8d Update newgrounds.js
  • 82a1f6c fix audio metadata and filename
  • d7b4ee6 fix video filenames
  • beff9aa change error type to make more sense
  • 250cbcf tests: add newgrounds tests
  • 49ba560 fix suggestions by @ihatespawn

📊 Changes

6 files changed (+152 additions, -1 deletions)

View changed files

📝 README.md (+1 -0)
📝 src/modules/processing/match.js (+8 -0)
➕ src/modules/processing/services/newgrounds.js (+95 -0)
📝 src/modules/processing/servicesConfig.json (+5 -0)
📝 src/modules/processing/servicesPatternTesters.js (+6 -1)
📝 src/util/tests.json (+37 -0)

📄 Description

A WIP pull request for adding Newgrounds support, from #620.
Would love some help with this, never worked with cobalt source before or Javascript.

Links supported:

Here is what's missing:

  • Video downloads don't have the correct file name, extension is undefined.
  • Audio links work, but the filename is incorrect (downloads as newgrounds_id.undefined)
  • Audio files do not have metadata attached, not sure how to do this currently.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/639 **Author:** [@hyperdefined](https://github.com/hyperdefined) **Created:** 7/18/2024 **Status:** ❌ Closed **Base:** `current` ← **Head:** `newgrounds-support` --- ### 📝 Commits (10+) - [`5efe510`](https://github.com/imputnet/cobalt/commit/5efe51098b13ec077401eca190df5bd4357a54f1) initial newgrounds support - [`5723239`](https://github.com/imputnet/cobalt/commit/5723239f1046c04d6d9c249888690fed988ff7bc) added video parsing - [`b219c3e`](https://github.com/imputnet/cobalt/commit/b219c3e9aabfd71c3c682d87a7ec2eec45dd13f6) error checking for parsing things - [`488ea8b`](https://github.com/imputnet/cobalt/commit/488ea8b1ecbe3e51e1f76c34abc6811e8a8f3a09) undo these testing things - [`27a1d8d`](https://github.com/imputnet/cobalt/commit/27a1d8dde377e0e9664b0b0c120163f453b1b9a9) Update newgrounds.js - [`82a1f6c`](https://github.com/imputnet/cobalt/commit/82a1f6ce45044ff2d8ce7903dcd98bdf6bfea24a) fix audio metadata and filename - [`d7b4ee6`](https://github.com/imputnet/cobalt/commit/d7b4ee6c06482bdfd6472673f2d8500a3bb05e44) fix video filenames - [`beff9aa`](https://github.com/imputnet/cobalt/commit/beff9aaff62f51d927d7509d55084e26837de613) change error type to make more sense - [`250cbcf`](https://github.com/imputnet/cobalt/commit/250cbcfac1d4036c915893fb160d022d9b212521) tests: add newgrounds tests - [`49ba560`](https://github.com/imputnet/cobalt/commit/49ba560304022f573a331acc17ffd826cbe21ad5) fix suggestions by @ihatespawn ### 📊 Changes **6 files changed** (+152 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -0) 📝 `src/modules/processing/match.js` (+8 -0) ➕ `src/modules/processing/services/newgrounds.js` (+95 -0) 📝 `src/modules/processing/servicesConfig.json` (+5 -0) 📝 `src/modules/processing/servicesPatternTesters.js` (+6 -1) 📝 `src/util/tests.json` (+37 -0) </details> ### 📄 Description A WIP pull request for adding Newgrounds support, from #620. Would love some help with this, never worked with cobalt source before or Javascript. Links supported: * https://www.newgrounds.com/portal/view/938050 * https://www.newgrounds.com/audio/listen/500476 Here is what's missing: - [x] Video downloads don't have the correct file name, extension is `undefined`. - [x] Audio links work, but the filename is incorrect (downloads as `newgrounds_id.undefined`) - [x] Audio files do not have metadata attached, not sure how to do this currently. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-09 10:08:36 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
3rd party app support
bug
can reproduce
can't reproduce
documentation
duplicate
feature request
help wanted
instance hosting help
invalid
main instance issue
need more info
needs fixing
next major
not an issue
pull-request
Mirrored from GitHub Pull Request
 question
region lock issue
security
service request
skill issue
web ui
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cobalt#1229
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?