[PR #464] [MERGED] Centralized environment variables and their default values in modules/config #1157

Closed
opened 2025-11-09 10:06:58 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/464
Author: @jsopn
Created: 4/28/2024
Status: Merged
Merged: 4/29/2024
Merged by: @dumbmoron

Base: currentHead: feat-config-refactoring


📝 Commits (4)

  • ae87c4e feat(config): centralized env variables and their default values
  • ab1cc1a fix: fip corsWildcard variable check in corsConfig
  • ee4992b fix(config): use already declared variables and default some strings to undefined
  • 8cd0bd3 fix: check processingPriority against NaN

📊 Changes

10 files changed (+68 additions, -42 deletions)

View changed files

📝 src/cobalt.js (+3 -5)
📝 src/core/api.js (+9 -9)
📝 src/core/web.js (+4 -4)
📝 src/modules/config.js (+29 -1)
📝 src/modules/pageRender/elements.js (+2 -2)
📝 src/modules/pageRender/page.js (+10 -10)
📝 src/modules/processing/cookie/manager.js (+2 -1)
📝 src/modules/processing/services/tiktok.js (+3 -4)
📝 src/modules/stream/manage.js (+3 -3)
📝 src/modules/stream/types.js (+3 -3)

📄 Description

centralized environment variables in modules/config as discussed with @dumbmoron in #463 pull request


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/464 **Author:** [@jsopn](https://github.com/jsopn) **Created:** 4/28/2024 **Status:** ✅ Merged **Merged:** 4/29/2024 **Merged by:** [@dumbmoron](https://github.com/dumbmoron) **Base:** `current` ← **Head:** `feat-config-refactoring` --- ### 📝 Commits (4) - [`ae87c4e`](https://github.com/imputnet/cobalt/commit/ae87c4e7ed60359b302cb27f67aa3024ff11418e) feat(config): centralized env variables and their default values - [`ab1cc1a`](https://github.com/imputnet/cobalt/commit/ab1cc1a2bfabf387294a7e1d6f70a33368b2bd8c) fix: fip `corsWildcard` variable check in `corsConfig` - [`ee4992b`](https://github.com/imputnet/cobalt/commit/ee4992b8ad1b367922cada814e681f8c482c7879) fix(config): use already declared variables and default some strings to undefined - [`8cd0bd3`](https://github.com/imputnet/cobalt/commit/8cd0bd35420d6b2bcee0598794ea2c3d4ffa25b8) fix: check processingPriority against NaN ### 📊 Changes **10 files changed** (+68 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `src/cobalt.js` (+3 -5) 📝 `src/core/api.js` (+9 -9) 📝 `src/core/web.js` (+4 -4) 📝 `src/modules/config.js` (+29 -1) 📝 `src/modules/pageRender/elements.js` (+2 -2) 📝 `src/modules/pageRender/page.js` (+10 -10) 📝 `src/modules/processing/cookie/manager.js` (+2 -1) 📝 `src/modules/processing/services/tiktok.js` (+3 -4) 📝 `src/modules/stream/manage.js` (+3 -3) 📝 `src/modules/stream/types.js` (+3 -3) </details> ### 📄 Description centralized environment variables in `modules/config` as discussed with @dumbmoron in #463 pull request --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-09 10:06:58 -06:00
Sign in to join this conversation.