[PR #253] [MERGED] fix handling of URLs containing utf-8 characters #1075

New Issue

GiteaMirror · 2025-11-09T10:05:16-06:00

GiteaMirror commented

2025-11-09 10:05:16 -06:00

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/253
Author: @dumbmoron
Created: 11/23/2023
Status: ✅ Merged
Merged: 11/23/2023
Merged by: @wukko

Base: current ← Head: fix-utf8-urls

📝 Commits (3)

190a013 api: url-encode UTF-8 characters in url
7468b80 reddit: don't include title in API request path
3ca65e0 reddit: remove the rest of references to title

📊 Changes

5 files changed (+5 additions, -7 deletions)

View changed files

📝 src/modules/api.js (+1 -1)
📝 src/modules/processing/match.js (+1 -2)
📝 src/modules/processing/services/reddit.js (+1 -1)
📝 src/modules/processing/servicesPatternTesters.js (+1 -2)
📝 src/modules/sub/utils.js (+1 -1)

📄 Description

this currently affects only reddit, but it should get fixed at the core of the problem instead of hacking around it somewhere else in the code

the main problem is that url-pattern doesn't like urls containing utf-8 characters (understandably)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/253 **Author:** [@dumbmoron](https://github.com/dumbmoron) **Created:** 11/23/2023 **Status:** ✅ Merged **Merged:** 11/23/2023 **Merged by:** [@wukko](https://github.com/wukko) **Base:** `current` ← **Head:** `fix-utf8-urls` --- ### 📝 Commits (3) - [`190a013`](https://github.com/imputnet/cobalt/commit/190a0131d4cbec2e867c2f29f24a889d9080356e) api: url-encode UTF-8 characters in url - [`7468b80`](https://github.com/imputnet/cobalt/commit/7468b803fbb8f2bf6ee341aaa9a1067f2f731854) reddit: don't include title in API request path - [`3ca65e0`](https://github.com/imputnet/cobalt/commit/3ca65e0daf6177c449b5b8d7201e43ba36dc21f3) reddit: remove the rest of references to title ### 📊 Changes **5 files changed** (+5 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/api.js` (+1 -1) 📝 `src/modules/processing/match.js` (+1 -2) 📝 `src/modules/processing/services/reddit.js` (+1 -1) 📝 `src/modules/processing/servicesPatternTesters.js` (+1 -2) 📝 `src/modules/sub/utils.js` (+1 -1) </details> ### 📄 Description this currently affects only reddit, but it should get fixed at the core of the problem instead of hacking around it somewhere else in the code the main problem is that `url-pattern` doesn't like urls containing utf-8 characters (understandably) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-09 10:05:16 -06:00

GiteaMirror closed this issue

2025-11-09 10:05:17 -06:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/cobalt#1075