[PR #243] [CLOSED] Improve Dockerfile #1072

Closed
opened 2025-11-09 10:05:13 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/243
Author: @Myzel394
Created: 11/10/2023
Status: Closed

Base: currentHead: improve-docker


📝 Commits (2)

  • cbfb843 fix: Harden Dockerfile
  • a6405dc fix: Remove redundant statement

📊 Changes

2 files changed (+15 additions, -7 deletions)

View changed files

.dockerignore (+5 -0)
📝 Dockerfile (+10 -7)

📄 Description

Some hardenings - When trying to execute this, I'm greeted with:

cobalt wasn't configured yet or configuration is invalid.
please run the setup script to fix this: npm run setup

this is kinda strange for a Dockerfile. I'd propose to make cobalt configurable via environmental variables. What do you think?


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/243 **Author:** [@Myzel394](https://github.com/Myzel394) **Created:** 11/10/2023 **Status:** ❌ Closed **Base:** `current` ← **Head:** `improve-docker` --- ### 📝 Commits (2) - [`cbfb843`](https://github.com/imputnet/cobalt/commit/cbfb8432f80d3aeef4deb36ab22fd060c0776450) fix: Harden Dockerfile - [`a6405dc`](https://github.com/imputnet/cobalt/commit/a6405dcd0c14c21c51338cdfb891c848ed06f937) fix: Remove redundant statement ### 📊 Changes **2 files changed** (+15 additions, -7 deletions) <details> <summary>View changed files</summary> ➕ `.dockerignore` (+5 -0) 📝 `Dockerfile` (+10 -7) </details> ### 📄 Description Some hardenings - When trying to execute this, I'm greeted with: ```bash cobalt wasn't configured yet or configuration is invalid. please run the setup script to fix this: npm run setup ``` this is kinda strange for a Dockerfile. I'd propose to make cobalt configurable via environmental variables. What do you think? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-09 10:05:13 -06:00
Sign in to join this conversation.