[PR #224] [MERGED] youtube: unify quality matching, slight cleanup #1061

Closed
opened 2025-11-09 10:05:00 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/224
Author: @dumbmoron
Created: 10/17/2023
Status: Merged
Merged: 1/31/2024
Merged by: @wukko

Base: currentHead: fix-single-quality


📝 Commits (3)

  • a4c7cc0 youtube: unify quality matching
  • 946bec6 youtube: slight cleanup & deduplication
  • e85b2ac youtube: clean up

📊 Changes

1 file changed (+27 additions, -30 deletions)

View changed files

📝 src/modules/processing/services/youtube.js (+27 -30)

📄 Description

fixes https://discord.com/channels/1049706293700591677/1049740124231061555/1163870548854579322:

It appears that some YouTube videos (like this one https://youtube.com/watch?v=uuAgccyZVJ8) are handled a bit weirdly by the quality settings, in particular this one cannot be downloaded in 144p or 240p and if these are provided as parameters to the API it downloads at the default 720p instead. Downloading at 360p works normally however. This only appears to affect some videos (such as some others uploaded on this channel) and most videos are downloaded as expected at 144 or 240p


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/224 **Author:** [@dumbmoron](https://github.com/dumbmoron) **Created:** 10/17/2023 **Status:** ✅ Merged **Merged:** 1/31/2024 **Merged by:** [@wukko](https://github.com/wukko) **Base:** `current` ← **Head:** `fix-single-quality` --- ### 📝 Commits (3) - [`a4c7cc0`](https://github.com/imputnet/cobalt/commit/a4c7cc0d354de3d551283b87142c27b27b28b769) youtube: unify quality matching - [`946bec6`](https://github.com/imputnet/cobalt/commit/946bec68c149a55951690d2c2b5e47d2fc09e3b9) youtube: slight cleanup & deduplication - [`e85b2ac`](https://github.com/imputnet/cobalt/commit/e85b2ace1415ca01b5d7f5f988b91f5cd974f21f) youtube: clean up ### 📊 Changes **1 file changed** (+27 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/processing/services/youtube.js` (+27 -30) </details> ### 📄 Description fixes https://discord.com/channels/1049706293700591677/1049740124231061555/1163870548854579322: > It appears that some YouTube videos (like this one https://youtube.com/watch?v=uuAgccyZVJ8) are handled a bit weirdly by the quality settings, in particular this one cannot be downloaded in 144p or 240p and if these are provided as parameters to the API it downloads at the default 720p instead. Downloading at 360p works normally however. This only appears to affect some videos (such as some others uploaded on this channel) and most videos are downloaded as expected at 144 or 240p --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-09 10:05:00 -06:00
Sign in to join this conversation.