try to close as many things as possible when shutting down
remove redundant (e.g. exit on process when listening for close) and straight up useless (disconnect) event listeners
send SIGKILL to ffmpeg process after timeout in case the ffmpeg process decides to hang when SIGTERM'd
cleanup
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/imputnet/cobalt/pull/225
**Author:** [@dumbmoron](https://github.com/dumbmoron)
**Created:** 10/19/2023
**Status:** ✅ Merged
**Merged:** 11/6/2023
**Merged by:** [@wukko](https://github.com/wukko)
**Base:** `current` ← **Head:** `stream-close-handling`
---
### 📝 Commits (8)
- [`9001d40`](https://github.com/imputnet/cobalt/commit/9001d401dae64579c647cf0f107685b7a8186446) stream: improve shutdown handling, minor clean up
- [`1508a0b`](https://github.com/imputnet/cobalt/commit/1508a0bff48049b92bdb8f1262fefd87c6f2b435) stream: send SIGKILL after timeout
- [`ed646b8`](https://github.com/imputnet/cobalt/commit/ed646b826db54ad3afd532eec51cdea29b090a08) stream: wrap abort controller in try-catch
- [`aabde22`](https://github.com/imputnet/cobalt/commit/aabde229ed39bab6701e39d545490fe9f20b0533) stream: generalize pipe event handling
- [`58f7ed7`](https://github.com/imputnet/cobalt/commit/58f7ed7827131aed59e4039e77606d095a5bf9bf) stream: use descriptive variables for i/o for better readability
- [`3307200`](https://github.com/imputnet/cobalt/commit/33072003bcb83a8f25ebb62143282817948ce7f2) stream: use strings for signals instead of number
- [`758bb8f`](https://github.com/imputnet/cobalt/commit/758bb8fef7f6322aee60edb9804164e0c3447bb4) types: added comments
- [`b01c9f3`](https://github.com/imputnet/cobalt/commit/b01c9f3e54789de25166115b92cec4f66683f22d) types: make streamVideoOnly more readable
### 📊 Changes
**2 files changed** (+89 additions, -74 deletions)
<details>
<summary>View changed files</summary>
📝 `package.json` (+1 -0)
📝 `src/modules/stream/types.js` (+88 -74)
</details>
### 📄 Description
- try to close as many things as possible when shutting down
- remove redundant (e.g. `exit` on process when listening for `close`) and straight up useless (`disconnect`) event listeners
- send SIGKILL to ffmpeg process after timeout in case the ffmpeg process decides to hang when SIGTERM'd
- cleanup
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/imputnet/cobalt/pull/225
Author: @dumbmoron
Created: 10/19/2023
Status: ✅ Merged
Merged: 11/6/2023
Merged by: @wukko
Base:
current← Head:stream-close-handling📝 Commits (8)
9001d40stream: improve shutdown handling, minor clean up1508a0bstream: send SIGKILL after timeouted646b8stream: wrap abort controller in try-catchaabde22stream: generalize pipe event handling58f7ed7stream: use descriptive variables for i/o for better readability3307200stream: use strings for signals instead of number758bb8ftypes: added commentsb01c9f3types: make streamVideoOnly more readable📊 Changes
2 files changed (+89 additions, -74 deletions)
View changed files
📝
package.json(+1 -0)📝
src/modules/stream/types.js(+88 -74)📄 Description
exiton process when listening forclose) and straight up useless (disconnect) event listeners🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.