github-starred/cobalt
2
0
Fork 0
mirror of https://github.com/imputnet/cobalt.git synced 2026-07-17 04:23:36 -05:00
Code Issues 4.7k Packages Projects Releases Wiki Activity

[PR #178] [MERGED] always send something on stream failure #1040

New Issue
Closed
opened 2025-11-09 10:04:36 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-09 10:04:36 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/178
Author: @dumbmoron
Created: 8/17/2023
Status: ✅ Merged
Merged: 8/20/2023
Merged by: @wukko

Base: current ← Head: stream-error-handling

📝 Commits (2)

  • b0bed82 always send something on stream failure
  • 36622fc collapsed two lines

📊 Changes

1 file changed (+22 additions, -25 deletions)

View changed files

📝 src/modules/stream/types.js (+22 -25)

📄 Description

prevents reverse proxies (namely nginx) from assuming the server died because of an empty response

specifically, this handles the situation where an exception / error occurs before any headers are set

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/178 **Author:** [@dumbmoron](https://github.com/dumbmoron) **Created:** 8/17/2023 **Status:** ✅ Merged **Merged:** 8/20/2023 **Merged by:** [@wukko](https://github.com/wukko) **Base:** `current` ← **Head:** `stream-error-handling` --- ### 📝 Commits (2) - [`b0bed82`](https://github.com/imputnet/cobalt/commit/b0bed82167cb86aaacc44003946f4acb487ba082) always send something on stream failure - [`36622fc`](https://github.com/imputnet/cobalt/commit/36622fc7acf6718a9c3964f8b50199b3057821be) collapsed two lines ### 📊 Changes **1 file changed** (+22 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `src/modules/stream/types.js` (+22 -25) </details> ### 📄 Description prevents reverse proxies (namely nginx) from assuming the server died because of an empty response specifically, this handles the situation where an exception / error occurs before any headers are set --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-09 10:04:36 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
3rd party app support
bug
can reproduce
can't reproduce
documentation
duplicate
feature request
help wanted
instance hosting help
invalid
main instance issue
need more info
needs fixing
next major
not an issue
pull-request
Mirrored from GitHub Pull Request
 question
region lock issue
security
service request
skill issue
web ui
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/cobalt#1040
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?