mirror of
https://github.com/imputnet/cobalt.git
synced 2026-05-23 23:01:04 -05:00
[PR #152] [CLOSED] Use Alpine in dockerfile, drop ffmpeg-static #1030
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/imputnet/cobalt/pull/152
Author: @dumbmoron
Created: 7/2/2023
Status: ❌ Closed
Base:
current← Head:new-dockerfile-drop-npm-ffmpeg📝 Commits (3)
91ddaf4Update Dockerfile1953042Drop ffmpeg-static21c63bareplace static-ffmpeg spawns with regular ffmpeg📊 Changes
3 files changed (+10 additions, -12 deletions)
View changed files
📝
Dockerfile(+7 -7)📝
package.json(+0 -1)📝
src/modules/stream/types.js(+3 -4)📄 Description
few things:
ffmpeg-staticnpm package and instead requiresffmpegto be installed when ran standalonenodeuser* could probably bring it down even more by somehow removing useless ffmpeg dependencies such as
sdl2- compiling it in-container instead of pulling from repo?seems to work but probably needs more testing idk
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.