[PR #152] [CLOSED] Use Alpine in dockerfile, drop ffmpeg-static #1030

Closed
opened 2025-11-09 10:04:24 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/imputnet/cobalt/pull/152
Author: @dumbmoron
Created: 7/2/2023
Status: Closed

Base: currentHead: new-dockerfile-drop-npm-ffmpeg


📝 Commits (3)

  • 91ddaf4 Update Dockerfile
  • 1953042 Drop ffmpeg-static
  • 21c63ba replace static-ffmpeg spawns with regular ffmpeg

📊 Changes

3 files changed (+10 additions, -12 deletions)

View changed files

📝 Dockerfile (+7 -7)
📝 package.json (+0 -1)
📝 src/modules/stream/types.js (+3 -4)

📄 Description

few things:

  • Drops ffmpeg-static npm package and instead requires ffmpeg to be installed when ran standalone
  • Docker image is now based on Alpine Linux instead of Debian and is 171MB lighter*
  • Docker image no longer runs under the root user but instead the node user

* could probably bring it down even more by somehow removing useless ffmpeg dependencies such as sdl2 - compiling it in-container instead of pulling from repo?

seems to work but probably needs more testing idk


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/imputnet/cobalt/pull/152 **Author:** [@dumbmoron](https://github.com/dumbmoron) **Created:** 7/2/2023 **Status:** ❌ Closed **Base:** `current` ← **Head:** `new-dockerfile-drop-npm-ffmpeg` --- ### 📝 Commits (3) - [`91ddaf4`](https://github.com/imputnet/cobalt/commit/91ddaf4d08d04fee6e7fd706f6f584e72b9c50e2) Update Dockerfile - [`1953042`](https://github.com/imputnet/cobalt/commit/1953042ba875b9cd62ec83b2b4cfd189548edca7) Drop ffmpeg-static - [`21c63ba`](https://github.com/imputnet/cobalt/commit/21c63ba6eed76a5e62f6f90a2749734a297acf2b) replace static-ffmpeg spawns with regular ffmpeg ### 📊 Changes **3 files changed** (+10 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+7 -7) 📝 `package.json` (+0 -1) 📝 `src/modules/stream/types.js` (+3 -4) </details> ### 📄 Description few things: - Drops `ffmpeg-static` npm package and instead requires `ffmpeg` to be installed when ran standalone - Docker image is now based on Alpine Linux instead of Debian and is 171MB lighter* - Docker image no longer runs under the root user but instead the `node` user \* could probably bring it down even more by somehow removing useless ffmpeg dependencies such as `sdl2` - compiling it in-container instead of pulling from repo? seems to work but probably needs more testing idk --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-09 10:04:24 -06:00
Sign in to join this conversation.