github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

Incorrect types for databaseHooks that were called with updateManyWithHooks #956

New Issue
Closed
opened 2026-03-13 08:11:59 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-03-13 08:11:59 -05:00
Owner
Copy Link

Originally created by @billdotdev on GitHub (Apr 1, 2025).

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

call authenticator.api.resetPassword()

const auth = betterAuth({
	emailAndPassword: {
		enabled: true,
		async sendResetPassword(data, request) {
			console.log(data);
		}
	},
	databaseHooks: {
		account: {
			update: {
				async after(account, context) {
					console.log(account, context);
				}
			}
		}
	}
});

await auth.api.forgetPassword({
	body: {
		email: 'example@mail.com'
	}
});

await auth.api.resetPassword({
	body: {
		token: 'token',
		newPassword: 'password'
	}
});

Current vs. Expected behavior

account returned from databaseHooks.account.update.after is a number but type suggests that it is an account.
It seems like updateManyWithHooks is only used in updatePassword

What version of Better Auth are you using?

1.2.5

Provide environment information

- OS: Mac
- Browser: chrome

Which area(s) are affected? (Select all that apply)

Types, Backend

Auth config (if applicable)

import { betterAuth } from "better-auth";
export const auth = betterAuth({
  emailAndPassword: {
    enabled: true,
    async sendResetPassword(data, request) {
      console.log(data);
    },
  },
  databaseHooks: {
    account: {
      update: {
        async after(account, context) {
          console.log(account, context);
        },
      },
    },
  },
});

Additional context

No response

Originally created by @billdotdev on GitHub (Apr 1, 2025). ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce call `authenticator.api.resetPassword()` ``` const auth = betterAuth({ emailAndPassword: { enabled: true, async sendResetPassword(data, request) { console.log(data); } }, databaseHooks: { account: { update: { async after(account, context) { console.log(account, context); } } } } }); await auth.api.forgetPassword({ body: { email: 'example@mail.com' } }); await auth.api.resetPassword({ body: { token: 'token', newPassword: 'password' } }); ``` ### Current vs. Expected behavior account returned from `databaseHooks.account.update.after` is a number but type suggests that it is an account. It seems like `updateManyWithHooks` is only used in `updatePassword` ### What version of Better Auth are you using? 1.2.5 ### Provide environment information ```bash - OS: Mac - Browser: chrome ``` ### Which area(s) are affected? (Select all that apply) Types, Backend ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth"; export const auth = betterAuth({ emailAndPassword: { enabled: true, async sendResetPassword(data, request) { console.log(data); }, }, databaseHooks: { account: { update: { async after(account, context) { console.log(account, context); }, }, }, }, }); ``` ### Additional context _No response_
GiteaMirror added the bug label 2026-03-13 08:11:59 -05:00
GiteaMirror commented 2026-03-13 08:12:00 -05:00
Author
Owner
Copy Link

@Kinfe123 commented on GitHub (Apr 2, 2025):

@billdotdev do you find this issue still persists ?

@Kinfe123 commented on GitHub (Apr 2, 2025): @billdotdev do you find this issue still persists ?
GiteaMirror commented 2026-03-13 08:12:01 -05:00
Author
Owner
Copy Link

@billdotdev commented on GitHub (Apr 3, 2025):

Yes, I am also using the prismaAdapter

@billdotdev commented on GitHub (Apr 3, 2025): Yes, I am also using the prismaAdapter
GiteaMirror commented 2026-03-13 08:12:02 -05:00
Author
Owner
Copy Link

@dosubot[bot] commented on GitHub (Jul 3, 2025):

Hi, @billdotdev. I'm Dosu, and I'm helping the better-auth team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • Incorrect type definitions for databaseHooks in updateManyWithHooks.
  • account is returned as a number instead of an account object.
  • Issue affects both types and backend functionality in version 1.2.5.
  • You confirmed the issue persists and mentioned using the prismaAdapter.

Next Steps:

  • Please confirm if this issue is still relevant to the latest version of the better-auth repository. If so, you can keep the discussion open by commenting here.
  • If there is no further activity, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot[bot] commented on GitHub (Jul 3, 2025): Hi, @billdotdev. I'm [Dosu](https://dosu.dev), and I'm helping the better-auth team manage their backlog. I'm marking this issue as stale. **Issue Summary:** - Incorrect type definitions for `databaseHooks` in `updateManyWithHooks`. - `account` is returned as a number instead of an account object. - Issue affects both types and backend functionality in version 1.2.5. - You confirmed the issue persists and mentioned using the prismaAdapter. **Next Steps:** - Please confirm if this issue is still relevant to the latest version of the better-auth repository. If so, you can keep the discussion open by commenting here. - If there is no further activity, this issue will be automatically closed in 7 days. Thank you for your understanding and contribution!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#956
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?