github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

Plugin: Passkey - addPasskey is missing error code in Promise #945

New Issue
Closed
opened 2026-03-13 08:10:59 -05:00 by GiteaMirror · 4 comments
GiteaMirror commented 2026-03-13 08:10:59 -05:00
Owner
Copy Link

Originally created by @DimitarY on GitHub (Mar 29, 2025).

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

  1. setup better auth to use passkeys
  2. attempt to use add passkey when session is not fresh

Current vs. Expected behavior

current: authClient.passkey.addPasskey function does not have a error code are return type
expected: authClient.passkey.addPasskey function include error code as return type

What version of Better Auth are you using?

1.2.5

Provide environment information

- OS: Rocky Linux 9
- Browser: Firefox

Which area(s) are affected? (Select all that apply)

Types

Auth config (if applicable)

import { betterAuth } from "better-auth"
export const auth = betterAuth({
  emailAndPassword: {  
    enabled: true
  },
});

Additional context

No response

Originally created by @DimitarY on GitHub (Mar 29, 2025). ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce 1. setup better auth to use passkeys 3. attempt to use add passkey when session is not fresh ### Current vs. Expected behavior current: authClient.passkey.addPasskey function does not have a error code are return type expected: authClient.passkey.addPasskey function include error code as return type ### What version of Better Auth are you using? 1.2.5 ### Provide environment information ```bash - OS: Rocky Linux 9 - Browser: Firefox ``` ### Which area(s) are affected? (Select all that apply) Types ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth" export const auth = betterAuth({ emailAndPassword: { enabled: true }, }); ``` ### Additional context _No response_
GiteaMirror added the bug label 2026-03-13 08:10:59 -05:00
GiteaMirror commented 2026-03-13 08:11:01 -05:00
Author
Owner
Copy Link

@Korabi123 commented on GitHub (Jun 16, 2025):

+1 did you find any way to get around this/display an error state when this error occurs?

@Korabi123 commented on GitHub (Jun 16, 2025): +1 did you find any way to get around this/display an error state when this error occurs?
GiteaMirror commented 2026-03-13 08:11:01 -05:00
Author
Owner
Copy Link

@DimitarY commented on GitHub (Jun 20, 2025):

This is working for me at the moment

const result = await auth.passkey.addPasskey({ name: values.name });

console.log("result", result);

if (result?.error) {
  return {
    success: false,
    error: result.error as {
      code?: string | undefined;
      message?: string | undefined;
      status: number;
      statusText: string;
    },
  };
} else {
  return { success: true, error: null };
}
@DimitarY commented on GitHub (Jun 20, 2025): This is working for me at the moment ```typescript const result = await auth.passkey.addPasskey({ name: values.name }); console.log("result", result); if (result?.error) { return { success: false, error: result.error as { code?: string | undefined; message?: string | undefined; status: number; statusText: string; }, }; } else { return { success: true, error: null }; } ```
GiteaMirror commented 2026-03-13 08:11:02 -05:00
Author
Owner
Copy Link

@Korabi123 commented on GitHub (Jul 8, 2025):

This is working for me at the moment

const result = await auth.passkey.addPasskey({ name: values.name });

console.log("result", result);

if (result?.error) {
return {
success: false,
error: result.error as {
code?: string | undefined;
message?: string | undefined;
status: number;
statusText: string;
},
};
} else {
return { success: true, error: null };
}

so in the if statement could I save the error message to a state variable or would I have to it somewhere else?

@Korabi123 commented on GitHub (Jul 8, 2025): > This is working for me at the moment > > const result = await auth.passkey.addPasskey({ name: values.name }); > > console.log("result", result); > > if (result?.error) { > return { > success: false, > error: result.error as { > code?: string | undefined; > message?: string | undefined; > status: number; > statusText: string; > }, > }; > } else { > return { success: true, error: null }; > } so in the if statement could I save the error message to a state variable or would I have to it somewhere else?
GiteaMirror commented 2026-03-13 08:11:03 -05:00
Author
Owner
Copy Link

@ping-maxwell commented on GitHub (Oct 5, 2025):

Hello all, this was fixed in https://github.com/better-auth/better-auth/pull/3966

@ping-maxwell commented on GitHub (Oct 5, 2025): Hello all, this was fixed in https://github.com/better-auth/better-auth/pull/3966
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#945
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?