github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-21 22:06:04 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #3045] 2FA OTP custom period setting wrong unit and defaults mismatch #9447

New Issue
Closed
opened 2026-04-13 04:54:49 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-13 04:54:49 -05:00
Owner
Copy Link

Originally created by @sabvente on GitHub (Jun 16, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/3045

To Reproduce

twoFactor({
  otpOptions: {
    period: 10
  }
})

Current vs. Expected behavior

Current behavior:

Unit mismatch

two-factor/otp/index.ts
treats period as minutes It converts it to milliseconds here (new Date expects milliseconds)

two-factor/index.ts
treats period as seconds (maxAge expects seconds)

Docs shows that "The period for otp in seconds."

Default value mismatch

two-factor/otp/index.ts
default value is 3 minutes

two-factor/index.ts
default value is 5 minutes

Docs shows that "The default period is 30 seconds for OTP.

#Expected behavior
Use the same units and same defaults everywhere.

What version of Better Auth are you using?

1.2.9

Which area(s) are affected? (Select all that apply)

Backend
Documentation

Originally created by @sabvente on GitHub (Jun 16, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/3045 ### To Reproduce ```js twoFactor({ otpOptions: { period: 10 } }) ``` ### Current vs. Expected behavior # Current behavior: ## Unit mismatch [two-factor/otp/index.ts](https://github.com/better-auth/better-auth/blob/e4bed5c7866c2fa9c268d7fa3e561eedcadc84f2/packages/better-auth/src/plugins/two-factor/otp/index.ts#L67C3-L67C46) treats period as **minutes** It converts it to milliseconds here (new Date expects milliseconds) [two-factor/index.ts](https://github.com/better-auth/better-auth/blob/e4bed5c7866c2fa9c268d7fa3e561eedcadc84f2/packages/better-auth/src/plugins/two-factor/index.ts#L299C7-L299C73) treats period as **seconds** (maxAge expects seconds) Docs shows that "The period for otp in **seconds**." ## Default value mismatch [two-factor/otp/index.ts](https://github.com/better-auth/better-auth/blob/e4bed5c7866c2fa9c268d7fa3e561eedcadc84f2/packages/better-auth/src/plugins/two-factor/otp/index.ts#L67C3-L67C46) default value is **3 minutes** [two-factor/index.ts](https://github.com/better-auth/better-auth/blob/e4bed5c7866c2fa9c268d7fa3e561eedcadc84f2/packages/better-auth/src/plugins/two-factor/index.ts#L299C7-L299C73) default value is **5 minutes** Docs shows that "The default period is **30** seconds for OTP. #Expected behavior Use the same units and same defaults everywhere. ### What version of Better Auth are you using? 1.2.9 ### Which area(s) are affected? (Select all that apply) Backend Documentation
GiteaMirror added the lockedbug labels 2026-04-13 04:54:49 -05:00
GiteaMirror commented 2026-04-13 04:54:51 -05:00
Author
Owner
Copy Link

@ping-maxwell commented on GitHub (Jul 1, 2025):

The value in the code is using milliseconds is intentional, we take the provided value which is in minutes, then convert to ms - this is fine.
However the docs are incorrect, so I will update that. As well as the default otp period being 5 mins will be updated too.

<!-- gh-comment-id:3021549957 --> @ping-maxwell commented on GitHub (Jul 1, 2025): The value in the code is using milliseconds is intentional, we take the provided value which is in minutes, then convert to ms - this is fine. However the docs are incorrect, so I will update that. As well as the default otp period being 5 mins will be updated too.
GiteaMirror commented 2026-04-13 04:54:53 -05:00
Author
Owner
Copy Link

@sabvente commented on GitHub (Jul 1, 2025):

@ping-maxwell Thank you for fixing this! :)

<!-- gh-comment-id:3025121682 --> @sabvente commented on GitHub (Jul 1, 2025): @ping-maxwell Thank you for fixing this! :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#9447
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?