github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 06:16:18 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #2969] defaultCookieAttributes are not used when using createAuthCookie() #9419

New Issue
Closed
opened 2026-04-13 04:52:54 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-13 04:52:54 -05:00
Owner
Copy Link

Originally created by @gregg-cbs on GitHub (Jun 10, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/2969

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

  1. I am using ctx.context.createAuthCookie("session_token")
  2. It returns cookie attributes but those attributes are not the defaultCookieAttributes i set in my betterAuth config,

Current vs. Expected behavior

I expect defaultCookieAttributes to be used when doing anything with cookies in betterAuth

What version of Better Auth are you using?

1.2.8

Provide environment information

Windows
Nodejs

Which area(s) are affected? (Select all that apply)

Backend

Auth config (if applicable)

export const guestSessionPlugin = (): BetterAuthPlugin => ({
  id: "guest-session-plugin",
  endpoints: {
    createGuestSession: createAuthEndpoint(
      "/guest-session/create",
      { method: "GET" },
      async (ctx) => {
        const c = ctx.context.createAuthCookie("session_token")
        c.attributes // c.secure is true
      }
    )
  }
})

auth = betterAuth({
  advanced: {
    defaultCookieAttributes: {
      secure: false, // as an example this is false (needed for safari local dev testing)
      httpOnly: true,
      sameSite: "none",
      partitioned: true
    }
  }
})

Additional context

No response

Originally created by @gregg-cbs on GitHub (Jun 10, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/2969 ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce 1. I am using `ctx.context.createAuthCookie("session_token")` 2. It returns cookie attributes but those attributes are not the defaultCookieAttributes i set in my betterAuth config, ### Current vs. Expected behavior I expect defaultCookieAttributes to be used when doing anything with cookies in betterAuth ### What version of Better Auth are you using? 1.2.8 ### Provide environment information ```bash Windows Nodejs ``` ### Which area(s) are affected? (Select all that apply) Backend ### Auth config (if applicable) ```typescript export const guestSessionPlugin = (): BetterAuthPlugin => ({ id: "guest-session-plugin", endpoints: { createGuestSession: createAuthEndpoint( "/guest-session/create", { method: "GET" }, async (ctx) => { const c = ctx.context.createAuthCookie("session_token") c.attributes // c.secure is true } ) } }) auth = betterAuth({ advanced: { defaultCookieAttributes: { secure: false, // as an example this is false (needed for safari local dev testing) httpOnly: true, sameSite: "none", partitioned: true } } }) ``` ### Additional context _No response_
GiteaMirror added the locked label 2026-04-13 04:52:54 -05:00
GiteaMirror commented 2026-04-13 04:52:57 -05:00
Author
Owner
Copy Link

@gregg-cbs commented on GitHub (Jun 10, 2025):

Even worse when u use the context to set the cookie it always changes secure to true:

        // create session cookie config
        const c = ctx.context.createAuthCookie("session_token")

        const cookie = {
          name: c.name, 
          token: mapped_session.token, 
          options: ctx.context.options.advanced?.defaultCookieAttributes
        }

       // cookie.options.secure is false (as expected)
        
        // sets the cookie using the above session cookie config
        ctx.setCookie(cookie.name, cookie.token, cookie.options);

       // now cookie.options.secure is true (not expected for ctx.setCookie to override my cookie options and change them)
<!-- gh-comment-id:2958693448 --> @gregg-cbs commented on GitHub (Jun 10, 2025): Even worse when u use the context to set the cookie it always changes secure to true: ```ts // create session cookie config const c = ctx.context.createAuthCookie("session_token") const cookie = { name: c.name, token: mapped_session.token, options: ctx.context.options.advanced?.defaultCookieAttributes } // cookie.options.secure is false (as expected) // sets the cookie using the above session cookie config ctx.setCookie(cookie.name, cookie.token, cookie.options); // now cookie.options.secure is true (not expected for ctx.setCookie to override my cookie options and change them) ```
GiteaMirror commented 2026-04-13 04:52:57 -05:00
Author
Owner
Copy Link

@gregg-cbs commented on GitHub (Jun 10, 2025):

It looks like betterAuth is fine. This is a cookie issue where if partitioned is true and samesite is none then secure is forced to true as part of cookie policies.

Setting partitioned to false and samesite to lax in development solved this issue for me.

<!-- gh-comment-id:2958738042 --> @gregg-cbs commented on GitHub (Jun 10, 2025): It looks like betterAuth is fine. This is a cookie issue where if partitioned is true and samesite is none then secure is forced to true as part of cookie policies. Setting partitioned to false and samesite to lax in development solved this issue for me.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#9419
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?