github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #2918] Clearing session data cookie fails for cross origin cookies - it does not use domain setting #9398

New Issue
Closed
opened 2026-04-13 04:50:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 04:50:38 -05:00
Owner
Copy Link

Originally created by @widavies on GitHub (Jun 5, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/2918

I believe this line is incorrect:

91d504d81b/packages/better-auth/src/api/routes/session.ts (L117)

It does not factor in the domain option

      crossSubDomainCookies: {
        enabled: true,
        domain: 'example.com',
      },

This causes the cookie to not get cleared:

Image

Originally created by @widavies on GitHub (Jun 5, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/2918 I believe this line is incorrect: https://github.com/better-auth/better-auth/blob/91d504d81bcea52a6785eec02dca1626f2b734e6/packages/better-auth/src/api/routes/session.ts#L117 It does not factor in the `domain` option ``` crossSubDomainCookies: { enabled: true, domain: 'example.com', }, ``` This causes the cookie to not get cleared: ![Image](https://github.com/user-attachments/assets/841e2810-15fb-4de8-854d-75544397ae15)
GiteaMirror added the locked label 2026-04-13 04:50:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#9398
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?