github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #2100] updateMemberRole only works if the updating user has a single role #9052

New Issue
Closed
opened 2026-04-13 04:20:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 04:20:21 -05:00
Owner
Copy Link

Originally created by @dustin-we on GitHub (Apr 3, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/2100

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

To reproduce:

  1. Create a better-auth instance with the organizations plugin. I don't think the database matters.
  2. Create a organization
  3. Update your own member role to two roles
    const { error } = await authClient.organization.updateMemberRole({ memberId: "YOUR_MEMBER_ID", role: ["owner", "admin"] });
  4. Do step 3 again

Current vs. Expected behavior

Currently:
The first time the member role is set, the "role" column in the "member" table will be set to "owner,admin", which is what I would expect.
The second time you do it, you get an error ROLE_NOT_FOUND.

I think the code for this endpoint is checking if the role "owner,admin" is present, not either one of them.

What version of Better Auth are you using?

1.2.5

Provide environment information

- OS: MacOs 15.4
- Browser: Chrome

Which area(s) are affected? (Select all that apply)

Backend

Auth config (if applicable)

import { betterAuth } from "better-auth"

export const auth = betterAuth({
  database: { dialect, type: "postgres" },
  emailAndPassword: {
    enabled: true,
    disableSignUp: true,
    requireEmailVerification: false,
    maxPasswordLength: 100,
    minPasswordLength: 8,
  },
  socialProviders: {
    microsoft: {
      enabled: true,
      clientId: process.env.MICROSOFT_CLIENT_ID as string,
      clientSecret: process.env.MICROSOFT_CLIENT_SECRET as string,
      tenantId: process.env.MICROSOFT_TENANT_ID as string,

      // tenantId: "common",
    },
  },
  plugins: [organization({ ac, roles }), admin()],
});

Additional context

In my example, I added custom roles to my better-auth instance. This bug occurs even if you didnt. As you can see in the example, I used the standard roles, 'admin', 'owner'

Originally created by @dustin-we on GitHub (Apr 3, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/2100 ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce To reproduce: 1. Create a better-auth instance with the organizations plugin. I don't think the database matters. 2. Create a organization 3. Update your own member role to two roles ` const { error } = await authClient.organization.updateMemberRole({ memberId: "YOUR_MEMBER_ID", role: ["owner", "admin"] }); ` 4. Do step 3 again ### Current vs. Expected behavior Currently: The first time the member role is set, the "role" column in the "member" table will be set to "owner,admin", which is what I would expect. The second time you do it, you get an error ROLE_NOT_FOUND. I think the code for this endpoint is checking if the role "owner,admin" is present, not either one of them. ### What version of Better Auth are you using? 1.2.5 ### Provide environment information ```bash - OS: MacOs 15.4 - Browser: Chrome ``` ### Which area(s) are affected? (Select all that apply) Backend ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth" export const auth = betterAuth({ database: { dialect, type: "postgres" }, emailAndPassword: { enabled: true, disableSignUp: true, requireEmailVerification: false, maxPasswordLength: 100, minPasswordLength: 8, }, socialProviders: { microsoft: { enabled: true, clientId: process.env.MICROSOFT_CLIENT_ID as string, clientSecret: process.env.MICROSOFT_CLIENT_SECRET as string, tenantId: process.env.MICROSOFT_TENANT_ID as string, // tenantId: "common", }, }, plugins: [organization({ ac, roles }), admin()], }); ``` ### Additional context In my example, I added custom roles to my better-auth instance. This bug occurs even if you didnt. As you can see in the example, I used the standard roles, 'admin', 'owner'
GiteaMirror added the lockedbug labels 2026-04-13 04:20:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#9052
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?