github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #2088] ctx.redirect doesn't redirect to custom url in databaseHooks #9045

New Issue
Closed
opened 2026-04-13 04:19:59 -05:00 by GiteaMirror · 4 comments
GiteaMirror commented 2026-04-13 04:19:59 -05:00
Owner
Copy Link

Originally created by @showduhtung on GitHub (Apr 2, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/2088

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

  1. Setup config:
databaseHooks: {
  user: {
    create: {
      before: async (user, ctx) => {
        const foundUser = await prisma.user.findUnique({
          where: { email: user.email },
        });
        if (!ctx) {
          throw new Error("Context is undefined");
        }
        if (foundUser === null) {
          throw ctx.redirect("/auth/error?error=Unauthorized");
        }
        return { ...ctx, data: user };
      },
    },
  },
},
  1. Go through login flow

Current vs. Expected behavior

Expected Behavior

When a user attempts to log in but doesn't exist in the database, they should be redirected to my custom error page at /auth/error?error=Unauthorized.

Current Behavior

Despite throwing ctx.redirect, users are still being sent to better-auth's default error page rather than my custom error page.

What version of Better Auth are you using?

1.1.17

Provide environment information

- OS: MacOS
- Browser: [Arc, Chrome]
- Framework: Next.js 15.2.4

Which area(s) are affected? (Select all that apply)

Client, Backend

Auth config (if applicable)

const auth = betterAuth({
  database: prismaAdapter(prisma, { provider: "postgresql" }),
  emailAndPassword: { enabled: false },
  socialProviders: {
    discord: { clientId: env.DISCORD_CLIENT_ID, clientSecret: env.DISCORD_CLIENT_SECRET },
  },

  databaseHooks: {
    user: {
      create: {
        before: async (user, ctx) => {
          const foundUser = await prisma.user.findUnique({
            where: { email: user.email },
          });

          if (!ctx) {
            throw new Error("Context is undefined");
          }

          if (foundUser === null) {
            throw ctx.redirect("/auth/error?error=Unauthorized");
          }
          return { ...ctx, data: user };
        },
      },
    },
  },
  ...options,
  plugins: [
    customSession(
      // eslint-disable-next-line @typescript-eslint/require-await
      async (args) => args,
      options,
    ),
  ],
});

Additional context

Description

I'm trying to redirect users to a custom error page when they attempt to log in but don't exist in my database. However, ctx.redirect doesn't seem to work as expected in the before hook of databaseHooks.user.create. I'm aware that there's an admin plugin or I could create a custom plugin, but this seems like it should be a simple redirect functionality. Any help would be greatly appreciated!

Originally created by @showduhtung on GitHub (Apr 2, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/2088 ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce 1. Setup config: ``` databaseHooks: { user: { create: { before: async (user, ctx) => { const foundUser = await prisma.user.findUnique({ where: { email: user.email }, }); if (!ctx) { throw new Error("Context is undefined"); } if (foundUser === null) { throw ctx.redirect("/auth/error?error=Unauthorized"); } return { ...ctx, data: user }; }, }, }, }, ``` 2. Go through login flow ### Current vs. Expected behavior ### Expected Behavior When a user attempts to log in but doesn't exist in the database, they should be redirected to my custom error page at /auth/error?error=Unauthorized. ### Current Behavior Despite throwing ctx.redirect, users are still being sent to better-auth's default error page rather than my custom error page. ### What version of Better Auth are you using? 1.1.17 ### Provide environment information ```bash - OS: MacOS - Browser: [Arc, Chrome] - Framework: Next.js 15.2.4 ``` ### Which area(s) are affected? (Select all that apply) Client, Backend ### Auth config (if applicable) ```typescript const auth = betterAuth({ database: prismaAdapter(prisma, { provider: "postgresql" }), emailAndPassword: { enabled: false }, socialProviders: { discord: { clientId: env.DISCORD_CLIENT_ID, clientSecret: env.DISCORD_CLIENT_SECRET }, }, databaseHooks: { user: { create: { before: async (user, ctx) => { const foundUser = await prisma.user.findUnique({ where: { email: user.email }, }); if (!ctx) { throw new Error("Context is undefined"); } if (foundUser === null) { throw ctx.redirect("/auth/error?error=Unauthorized"); } return { ...ctx, data: user }; }, }, }, }, ...options, plugins: [ customSession( // eslint-disable-next-line @typescript-eslint/require-await async (args) => args, options, ), ], }); ``` ### Additional context ### Description I'm trying to redirect users to a custom error page when they attempt to log in but don't exist in my database. However, ctx.redirect doesn't seem to work as expected in the before hook of databaseHooks.user.create. I'm aware that there's an admin plugin or I could create a custom plugin, but this seems like it should be a simple redirect functionality. Any help would be greatly appreciated!
GiteaMirror added the lockedbug labels 2026-04-13 04:19:59 -05:00
GiteaMirror commented 2026-04-13 04:20:01 -05:00
Author
Owner
Copy Link

@showduhtung commented on GitHub (Apr 2, 2025):

Note, I've tried to use the onApiError option, (https://www.better-auth.com/docs/reference/options#onapierror), and it seems like this option doesn't apply on a thrown ApiError in databaseHooks

<!-- gh-comment-id:2772521207 --> @showduhtung commented on GitHub (Apr 2, 2025): Note, I've tried to use the `onApiError` option, (https://www.better-auth.com/docs/reference/options#onapierror), and it seems like this option doesn't apply on a thrown ApiError in `databaseHooks`
GiteaMirror commented 2026-04-13 04:20:02 -05:00
Author
Owner
Copy Link

@s3f5 commented on GitHub (Apr 6, 2025):

@showduhtung to disable a sign up for new users you could use => disableSignUp or disableImplicitSignUp on the provider and create a custom error page for /auth/error?error=signup_disabled.

<!-- gh-comment-id:2781322043 --> @s3f5 commented on GitHub (Apr 6, 2025): @showduhtung to disable a sign up for new users you could use => [disableSignUp or disableImplicitSignUp](https://www.better-auth.com/docs/concepts/oauth#other-provider-configurations) on the provider and create a custom error page for /auth/error?error=signup_disabled.
GiteaMirror commented 2026-04-13 04:20:02 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Apr 12, 2025):

this should work properly staring from 1.2.6-beta.13

<!-- gh-comment-id:2799038711 --> @Bekacru commented on GitHub (Apr 12, 2025): this should work properly staring from `1.2.6-beta.13`
GiteaMirror commented 2026-04-13 04:20:03 -05:00
Author
Owner
Copy Link

@showduhtung commented on GitHub (Apr 18, 2025):

@showduhtung to disable a sign up for new users you could use => disableSignUp or disableImplicitSignUp on the provider and create a custom error page for /auth/error?error=signup_disabled.

Oh disableImplicitSignUp looks quite promising. I think it won't fully cover my problem where I want to conditionally redirect to a custom error page, but it seems helpful. I'll give it a try

<!-- gh-comment-id:2814605953 --> @showduhtung commented on GitHub (Apr 18, 2025): > [@showduhtung](https://github.com/showduhtung) to disable a sign up for new users you could use => [disableSignUp or disableImplicitSignUp](https://www.better-auth.com/docs/concepts/oauth#other-provider-configurations) on the provider and create a custom error page for /auth/error?error=signup_disabled. Oh `disableImplicitSignUp ` looks quite promising. I think it won't fully cover my problem where I want to conditionally redirect to a custom error page, but it seems helpful. I'll give it a try
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#9045
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?