github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #1879] Unncecessary hashing of password in username plugin #8957

New Issue
Closed
opened 2026-04-13 04:12:20 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-04-13 04:12:20 -05:00
Owner
Copy Link

Originally created by @VIEWVIEWVIEW on GitHub (Mar 19, 2025).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/1879

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

I'm currently forking the username plugin for my own needs, and I stumbled accross a call on hash in the signInUsername method when the user is not found. I believe L146 is unnecessary here, as we will throw an error anyway and the context won't do anything with the hashed pw.

90f15abc95/packages/better-auth/src/plugins/username/index.ts (L145-L151)

Current vs. Expected behavior

What version of Better Auth are you using?

latest

Provide environment information

-

Which area(s) are affected? (Select all that apply)

Backend

Auth config (if applicable)

Additional context

No response

Originally created by @VIEWVIEWVIEW on GitHub (Mar 19, 2025). Original GitHub issue: https://github.com/better-auth/better-auth/issues/1879 ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce I'm currently forking the username plugin for my own needs, and I stumbled accross a call on ``hash`` in the ``signInUsername`` method when the user is not found. I believe **L146** is unnecessary here, as we will throw an error anyway and the context won't do anything with the hashed pw. https://github.com/better-auth/better-auth/blob/90f15abc957a789876f2bd68aa64eb6df037ab6e/packages/better-auth/src/plugins/username/index.ts#L145-L151 ### Current vs. Expected behavior - ### What version of Better Auth are you using? latest ### Provide environment information ```bash - ``` ### Which area(s) are affected? (Select all that apply) Backend ### Auth config (if applicable) ```typescript ``` ### Additional context _No response_
GiteaMirror added the lockedbug labels 2026-04-13 04:12:20 -05:00
GiteaMirror commented 2026-04-13 04:12:22 -05:00
Author
Owner
Copy Link

@SiNONiMiTY commented on GitHub (Apr 17, 2025):

this is also present on the signInEmail method

8931a1f969/packages/better-auth/src/api/routes/sign-in.ts (L459)

<!-- gh-comment-id:2813880241 --> @SiNONiMiTY commented on GitHub (Apr 17, 2025): this is also present on the signInEmail method https://github.com/better-auth/better-auth/blob/8931a1f969a44d0f015a2509c5a5765ddfd6b34e/packages/better-auth/src/api/routes/sign-in.ts#L459
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#8957
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?