github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

API Key Plugin: Plugin option ratelimit.enabled not used on create apikey #879

New Issue
Closed
opened 2026-03-13 08:08:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 08:08:34 -05:00
Owner
Copy Link

Originally created by @ismael-iskauskas on GitHub (Mar 19, 2025).

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

set the option ratelimit.enabled = false in betterauth plugin config

create an apikey from the client. rateLimitEnabled is true in table apikey

Current vs. Expected behavior

expected rateLimitEnabled === false in table apikey
current rateLimitEnabled === true

Solution:
in file packages/better-auth/src/plugins/api-key/routes/create-api-key.ts
line 271 change

rateLimitEnabled: rateLimitEnabled ?? true

to

rateLimitEnabled: rateLimitEnabled ?? opts.rateLimit.enabled ?? true

What version of Better Auth are you using?

1.2.4

Provide environment information

doesent matter

Which area(s) are affected? (Select all that apply)

Backend

Auth config (if applicable)

import { betterAuth } from "better-auth"
export const auth = betterAuth({
  emailAndPassword: {  
    enabled: true
  },
plugins: [
      openAPI({}),
      admin(),
      apiKey({
        schema: {
          apikey: {
            modelName: 'auth.api_keys',
            fields: {},
          },
        },
        rateLimit: {
          enabled: false,
          maxRequests: 1000,
          timeWindow: 1000 * 60,
        },
      }),
      twoFactor({
        schema: {
          twoFactor: {
            modelName: 'auth.two_factors',
            fields: {},
          },
        },
      }),
    ],
});

Additional context

No response

Originally created by @ismael-iskauskas on GitHub (Mar 19, 2025). ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce set the option ratelimit.enabled = false in betterauth plugin config create an apikey from the client. rateLimitEnabled is true in table apikey ### Current vs. Expected behavior expected rateLimitEnabled === false in table apikey current rateLimitEnabled === true Solution: in file packages/better-auth/src/plugins/api-key/routes/create-api-key.ts line 271 change ``` ts rateLimitEnabled: rateLimitEnabled ?? true ``` to ``` ts rateLimitEnabled: rateLimitEnabled ?? opts.rateLimit.enabled ?? true ``` ### What version of Better Auth are you using? 1.2.4 ### Provide environment information ```bash doesent matter ``` ### Which area(s) are affected? (Select all that apply) Backend ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth" export const auth = betterAuth({ emailAndPassword: { enabled: true }, plugins: [ openAPI({}), admin(), apiKey({ schema: { apikey: { modelName: 'auth.api_keys', fields: {}, }, }, rateLimit: { enabled: false, maxRequests: 1000, timeWindow: 1000 * 60, }, }), twoFactor({ schema: { twoFactor: { modelName: 'auth.two_factors', fields: {}, }, }, }), ], }); ``` ### Additional context _No response_
GiteaMirror added the bug label 2026-03-13 08:08:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#879
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?