github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #996] Email Verification isn't logging the user in #8541

New Issue
Closed
opened 2026-04-13 03:38:48 -05:00 by GiteaMirror · 10 comments
GiteaMirror commented 2026-04-13 03:38:48 -05:00
Owner
Copy Link

Originally created by @daveycodez on GitHub (Dec 23, 2024).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/996

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

Click an email verification link, and you have to enter the email and password again.

Current vs. Expected behavior

Email Verification link should act like a magic link and log the user in

What version of Better Auth are you using?

1.1.2

Provide environment information

Nextjs

Which area(s) are affected? (Select all that apply)

Client

Auth config (if applicable)

No response

Additional context

No response

Originally created by @daveycodez on GitHub (Dec 23, 2024). Original GitHub issue: https://github.com/better-auth/better-auth/issues/996 ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce Click an email verification link, and you have to enter the email and password again. ### Current vs. Expected behavior Email Verification link should act like a magic link and log the user in ### What version of Better Auth are you using? 1.1.2 ### Provide environment information ```bash Nextjs ``` ### Which area(s) are affected? (Select all that apply) Client ### Auth config (if applicable) _No response_ ### Additional context _No response_
GiteaMirror added the lockedbug labels 2026-04-13 03:38:48 -05:00
GiteaMirror commented 2026-04-13 03:38:49 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Dec 23, 2024):

you need to set emailVerification.autoSignInAfterVerification to sign in after verification.

<!-- gh-comment-id:2559358119 --> @Bekacru commented on GitHub (Dec 23, 2024): you need to set `emailVerification.autoSignInAfterVerification` to sign in after verification.
GiteaMirror commented 2026-04-13 03:38:49 -05:00
Author
Owner
Copy Link

@daveycodez commented on GitHub (Dec 23, 2024):

Hmm I tried that option and it doesn't seem to be working. I am using anonymous users as well so maybe that is affecting it somehow?

    emailAndPassword: { enabled: true, requireEmailVerification: true },
    emailVerification: {
        sendVerificationEmail: async ({ user, url, token }, request) => {
            await resend.emails.send({
                from: "NEW-TECH <noreply@auth.newtech.dev>",
                to: user.email,
                subject: "Verify your email address",
                react: EmailTemplate({ preview: "Verify Email", content: "Click the button below to verify your email.", action: "Vefify Email", confirmationUrl: url })
            })
        },
        autoSignInAfterVerification: true,
        sendOnSignUp: true
    },
<!-- gh-comment-id:2559365835 --> @daveycodez commented on GitHub (Dec 23, 2024): Hmm I tried that option and it doesn't seem to be working. I am using anonymous users as well so maybe that is affecting it somehow? ```ts emailAndPassword: { enabled: true, requireEmailVerification: true }, emailVerification: { sendVerificationEmail: async ({ user, url, token }, request) => { await resend.emails.send({ from: "NEW-TECH <noreply@auth.newtech.dev>", to: user.email, subject: "Verify your email address", react: EmailTemplate({ preview: "Verify Email", content: "Click the button below to verify your email.", action: "Vefify Email", confirmationUrl: url }) }) }, autoSignInAfterVerification: true, sendOnSignUp: true }, ```
GiteaMirror commented 2026-04-13 03:38:50 -05:00
Author
Owner
Copy Link

@daveycodez commented on GitHub (Dec 23, 2024):

Okay I've verified that it is not working if you are currently logged in as an anonymous user, it should trigger the accounts merging like a normal login or sign up. Magic Link isn't having this issue.

<!-- gh-comment-id:2559400186 --> @daveycodez commented on GitHub (Dec 23, 2024): Okay I've verified that it is not working if you are currently logged in as an anonymous user, it should trigger the accounts merging like a normal login or sign up. Magic Link isn't having this issue.
GiteaMirror commented 2026-04-13 03:38:50 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Dec 23, 2024):

that is cause it only applies if there is no active session at the time of verification. Verification isn't exactly a magic link or a way of signing in, so it doesn't override the current session or link an existing anonymous account upon verification.

<!-- gh-comment-id:2559644227 --> @Bekacru commented on GitHub (Dec 23, 2024): that is cause it only applies if there is no active session at the time of verification. Verification isn't exactly a magic link or a way of signing in, so it doesn't override the current session or link an existing anonymous account upon verification.
GiteaMirror commented 2026-04-13 03:38:50 -05:00
Author
Owner
Copy Link

@daveycodez commented on GitHub (Dec 23, 2024):

Need a way for email verification to also function as a magic link, or to just have the email verification trigger send the magic link instead. Otherwise this makes the anonymous users feature unusable

<!-- gh-comment-id:2560115491 --> @daveycodez commented on GitHub (Dec 23, 2024): Need a way for email verification to also function as a magic link, or to just have the email verification trigger send the magic link instead. Otherwise this makes the anonymous users feature unusable
GiteaMirror commented 2026-04-13 03:38:51 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Dec 23, 2024):

hmm why not send them a magic link?

<!-- gh-comment-id:2560118756 --> @Bekacru commented on GitHub (Dec 23, 2024): hmm why not send them a magic link?
GiteaMirror commented 2026-04-13 03:38:51 -05:00
Author
Owner
Copy Link

@daveycodez commented on GitHub (Dec 23, 2024):

Well it still needs to require email verification on signup, so signup with password needs to return a null token

<!-- gh-comment-id:2560122140 --> @daveycodez commented on GitHub (Dec 23, 2024): Well it still needs to require email verification on signup, so signup with password needs to return a null token
GiteaMirror commented 2026-04-13 03:38:51 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Dec 23, 2024):

yeah actually you're right. It make sense to log them in on anonymous case. if verification is required it'd be a blocker.

<!-- gh-comment-id:2560125659 --> @Bekacru commented on GitHub (Dec 23, 2024): yeah actually you're right. It make sense to log them in on anonymous case. if verification is required it'd be a blocker.
GiteaMirror commented 2026-04-13 03:38:52 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Dec 23, 2024):

we'll generate new session if the email don't match on verification

<!-- gh-comment-id:2560126286 --> @Bekacru commented on GitHub (Dec 23, 2024): we'll generate new session if the email don't match on verification
GiteaMirror commented 2026-04-13 03:38:53 -05:00
Author
Owner
Copy Link

@daveycodez commented on GitHub (Dec 23, 2024):

Yea also to note, Magic Link isn't working if the email isn't verified and requireVerification is true. Magic Link should verify the email of an unverified email account on click. Magic Link & Email Verification function should be pretty much identical except for the text written in the email

<!-- gh-comment-id:2560127621 --> @daveycodez commented on GitHub (Dec 23, 2024): Yea also to note, Magic Link isn't working if the email isn't verified and requireVerification is true. Magic Link should verify the email of an unverified email account on click. Magic Link & Email Verification function should be pretty much identical except for the text written in the email
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#8541
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?