github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #801] get-session endpoint returning 200 on error #8443

New Issue
Closed
opened 2026-04-13 03:30:50 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-13 03:30:50 -05:00
Owner
Copy Link

Originally created by @awesomepandapig on GitHub (Dec 7, 2024).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/801

Currently when querying /api/auth/get-session without a valid session token returns null with a 200 response status.

I believe that this endpoint should instead return a 400 error indicating that the request is missing a valid token, or a 401/403 if the token is malformed or not valid for the particular resource.

Without proper error codes validation is much more difficult.

Originally created by @awesomepandapig on GitHub (Dec 7, 2024). Original GitHub issue: https://github.com/better-auth/better-auth/issues/801 Currently when querying `/api/auth/get-session` without a valid session token returns `null` with a `200` response status. I believe that this endpoint should instead return a `400` error indicating that the request is missing a valid token, or a `401/403` if the token is malformed or not valid for the particular resource. Without proper error codes validation is much more difficult.
GiteaMirror added the locked label 2026-04-13 03:30:50 -05:00
GiteaMirror commented 2026-04-13 03:30:51 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Dec 7, 2024):

We're returning null to stay consistent with auth.api.getSession. Users won’t expect this to throw an error since it's primarily used in middleware or other contexts where you need to check if a session exists. Plus, throwing an error would generate unnecessary logs if you're using monitoring services for expected behavior. On the client, you can check if isPending is false and data is still null to determine whether the session was found.

<!-- gh-comment-id:2524990614 --> @Bekacru commented on GitHub (Dec 7, 2024): We're returning `null` to stay consistent with `auth.api.getSession`. Users won’t expect this to throw an error since it's primarily used in middleware or other contexts where you need to check if a session exists. Plus, throwing an error would generate unnecessary logs if you're using monitoring services for expected behavior. On the client, you can check if `isPending` is `false` and `data` is still `null` to determine whether the session was found.
GiteaMirror commented 2026-04-13 03:30:51 -05:00
Author
Owner
Copy Link

@awesomepandapig commented on GitHub (Dec 7, 2024):

Hmmm... I see. I am using express as my backend so I was thinking more in terms of an explicit client-server model where the server would be passing explicit error messages to the client if the session is invalid or DNE.

For now, though, data being null works great with my Next.JS middleware.

<!-- gh-comment-id:2524992157 --> @awesomepandapig commented on GitHub (Dec 7, 2024): Hmmm... I see. I am using express as my backend so I was thinking more in terms of an explicit client-server model where the server would be passing explicit error messages to the client if the session is invalid or DNE. For now, though, data being null works great with my Next.JS middleware.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#8443
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?