github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #772] OAuth Provider doesn't update user #8423

New Issue
Closed
opened 2026-04-13 03:29:25 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-13 03:29:25 -05:00
Owner
Copy Link

Originally created by @skip-pp on GitHub (Dec 5, 2024).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/772

Describe the bug

If I login using the genericOAuth plugin, custom attributes from the provider are not updated in the DB if a user exist.

I'm using keycloak, with groups attributes. Each group has the same attribute key, only the value differ.
If I'm in the group1 with an attribute like foo: bar, user is created in the DB with the value.
If I logout, switch to group2 with the same attribute key but with a different value foo: xyz, login again, the user in the DB is not updated

To Reproduce

Steps to reproduce the behavior:

With empty DB

  1. Login for the first time using genericOAuth plugin
  2. User is created with correct keycloak group attribute in DB : foo: bar
  3. Logout
  4. Change user group in keycloak (group attribute become : foo: xyz)
  5. Login
  6. DB user is not updated (attribute is still : foo: bar)

Output from mapProfileToUser :

{
  ...,
  foo: xyz
}

Output from session :

{
  session: {
    ...,
  },
  user: {
    ...,
    foo: bar,
  }
}
Originally created by @skip-pp on GitHub (Dec 5, 2024). Original GitHub issue: https://github.com/better-auth/better-auth/issues/772 **Describe the bug** If I login using the genericOAuth plugin, custom attributes from the provider are not updated in the DB if a user exist. I'm using keycloak, with groups attributes. Each group has the same attribute key, only the value differ.\ If I'm in the group1 with an attribute like **foo: bar**, user is created in the DB with the value.\ If I logout, switch to group2 with the same attribute key but with a different value **foo: xyz**, login again, the user in the DB is not updated **To Reproduce** Steps to reproduce the behavior: *With empty DB* 1. Login for the first time using genericOAuth plugin 2. User is created with correct keycloak group attribute in DB : **foo: bar** 3. Logout 4. Change user group in keycloak (group attribute become : **foo: xyz**) 5. Login 6. DB user is not updated (attribute is still : **foo: bar**) Output from mapProfileToUser : ```ts { ..., foo: xyz } ``` Output from session : ```ts { session: { ..., }, user: { ..., foo: bar, } } ```
GiteaMirror added the locked label 2026-04-13 03:29:25 -05:00
GiteaMirror commented 2026-04-13 03:29:27 -05:00
Author
Owner
Copy Link

@skip-pp commented on GitHub (Dec 18, 2024):

bug is still here. user is not updated on oauth login
better-auth: 1.0.22

<!-- gh-comment-id:2550948474 --> @skip-pp commented on GitHub (Dec 18, 2024): bug is still here. user is not updated on oauth login better-auth: 1.0.22
GiteaMirror commented 2026-04-13 03:29:28 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Dec 18, 2024):

@skip-pp we've actually removed it altogether after reconsideration. Since user info is managed by the app after registration for example, if the user updates their name in your app, it shouldn't be overridden on the next re-login because they've also updated their with the provider.

<!-- gh-comment-id:2550966153 --> @Bekacru commented on GitHub (Dec 18, 2024): @skip-pp we've actually removed it altogether after reconsideration. Since user info is managed by the app after registration for example, if the user updates their name in your app, it shouldn't be overridden on the next re-login because they've also updated their with the provider.
GiteaMirror commented 2026-04-13 03:29:29 -05:00
Author
Owner
Copy Link

@cookli0721 commented on GitHub (Mar 24, 2025):

In a similar situation, my application is an internal company platform where user information depends on updates from a unified provider. Could you provide a configuration option to allow us to decide whether to update user information or not?

<!-- gh-comment-id:2747415832 --> @cookli0721 commented on GitHub (Mar 24, 2025): In a similar situation, my application is an internal company platform where user information depends on updates from a unified provider. Could you provide a configuration option to allow us to decide whether to update user information or not?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#8423
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?