github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #441] Email Validity is checked twice in sign-in route handler #8275

New Issue
Closed
opened 2026-04-13 03:21:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 03:21:22 -05:00
Owner
Copy Link

Originally created by @itsderinger on GitHub (Nov 7, 2024).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/441

Describe the bug
The validity of the email input is checked twice in the route handler for the sign-in.

To Reproduce
The duplicate validity check can be found in lines 93-98 of /src/api/routes/sign-in.ts (Link). The check, however, is already performed here.

Expected behavior
The validity should only be checked once to make the code base more concise and avoid confusion in the future.
It's a fairly easy fix - happy to create a PR. :)

Originally created by @itsderinger on GitHub (Nov 7, 2024). Original GitHub issue: https://github.com/better-auth/better-auth/issues/441 **Describe the bug** The validity of the email input is checked twice in the route handler for the `sign-in`. **To Reproduce** The duplicate validity check can be found in lines 93-98 of `/src/api/routes/sign-in.ts` ([Link](https://github.com/better-auth/better-auth/blob/main/packages/better-auth/src/api/routes/sign-in.ts#L93-L98)). The check, however, is already performed [here](https://github.com/better-auth/better-auth/blob/main/packages/better-auth/src/api/routes/sign-in.ts#L87-L92). **Expected behavior** The validity should only be checked once to make the code base more concise and avoid confusion in the future. It's a fairly easy fix - happy to create a PR. :)
GiteaMirror added the locked label 2026-04-13 03:21:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#8275
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?