github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[GH-ISSUE #150] Q: Why is it not Node-independent? #8149

New Issue
Closed
opened 2026-04-13 03:13:48 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-13 03:13:48 -05:00
Owner
Copy Link

Originally created by @k-kozika on GitHub (Oct 12, 2024).
Original GitHub issue: https://github.com/better-auth/better-auth/issues/150

Here is an import that uses node:
Why is Scrypt encryption possible using Oslo or @noble/hashes but they are not used?

Originally created by @k-kozika on GitHub (Oct 12, 2024). Original GitHub issue: https://github.com/better-auth/better-auth/issues/150 [Here](https://github.com/better-auth/better-auth/blob/dfbcbdf5acecee388c8cf60acdadf8228a0e91ad/packages/better-auth/src/crypto/password.ts#L1) is an import that uses `node:` Why is Scrypt encryption possible using [`Oslo`](https://oslo.js.org/reference/password/Scrypt/) or [`@noble/hashes`](https://github.com/paulmillr/noble-hashes?tab=readme-ov-file#scrypt) but they are not used?
GiteaMirror added the locked label 2026-04-13 03:13:48 -05:00
GiteaMirror commented 2026-04-13 03:13:49 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Oct 12, 2024):

Our implementation is similar to Oslo's, which also uses "node:crypto." But, because Oslo uses classes, we ran into an issue where the generateKey method lost its reference after passing through our init context. Since "node:crypto" is already supported by multiple runtimes, we opted to continue using it rather than switching to @noble/hashes, even though noble doesn't rely on Node's implementation.

<!-- gh-comment-id:2408460663 --> @Bekacru commented on GitHub (Oct 12, 2024): Our implementation is similar to Oslo's, which also uses "node:crypto." But, because Oslo uses classes, we ran into an issue where the `generateKey` method lost its reference after passing through our init context. Since "node:crypto" is already supported by multiple runtimes, we opted to continue using it rather than switching to `@noble/hashes`, even though noble doesn't rely on Node's implementation.
GiteaMirror commented 2026-04-13 03:13:50 -05:00
Author
Owner
Copy Link

@k-kozika commented on GitHub (Oct 12, 2024):

I see.

<!-- gh-comment-id:2408477692 --> @k-kozika commented on GitHub (Oct 12, 2024): I see.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label locked
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#8149
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?