github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8318] [CLOSED] feat: add meaningful prefixes to verification API identifiers #7895

New Issue
Closed
opened 2026-03-13 13:52:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:52:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8318
Author: @himself65
Created: 3/3/2026
Status: ❌ Closed

Base: canary ← Head: worktree-verification-api-prefixes

📝 Commits (1)

  • b128c33 feat: add meaningful prefixes to verification API identifiers

📊 Changes

7 files changed (+36 additions, -30 deletions)

View changed files

📝 packages/better-auth/src/plugins/magic-link/index.ts (+11 -5)
📝 packages/better-auth/src/plugins/magic-link/magic-link.test.ts (+2 -2)
📝 packages/better-auth/src/plugins/mcp/authorize.ts (+1 -1)
📝 packages/better-auth/src/plugins/mcp/index.ts (+3 -3)
📝 packages/better-auth/src/plugins/oidc-provider/authorize.ts (+1 -1)
📝 packages/better-auth/src/plugins/oidc-provider/index.ts (+7 -7)
📝 packages/better-auth/src/plugins/phone-number/routes.ts (+11 -11)

📄 Description

Summary

Follow-up to #7600 — extends the magic-link: prefix pattern to all plugins that store data in the shared verification table without a meaningful prefix.

  • magic-link: adds magic-link:${token} prefix with backward-compatibility fallback for tokens stored before this change
  • phone-number: adds phone-number:${phoneNumber} prefix (basic OTP) and phone-number:${phoneNumber}:request-password-reset (password reset OTP)
  • oidc-provider: adds oidc-code:${code} prefix for authorization codes (both initial store and consent-flow update)
  • mcp: adds mcp-code:${code} prefix for authorization codes

Already had prefixes (no changes needed): one-time-token:, siwe:, email-verification-otp-/dynamic OTP prefixes, 2fa-otp-, trust-device-, reset-password:, 2fa-.

Test plan

  • All existing magic-link tests pass (16 tests)
  • All existing phone-number tests pass (26 tests)
  • All existing oidc-provider tests pass (35 tests)
  • All existing mcp tests pass (36 tests)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8318 **Author:** [@himself65](https://github.com/himself65) **Created:** 3/3/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `worktree-verification-api-prefixes` --- ### 📝 Commits (1) - [`b128c33`](https://github.com/better-auth/better-auth/commit/b128c3399133fe83bc0b93a4cf551c797285be17) feat: add meaningful prefixes to verification API identifiers ### 📊 Changes **7 files changed** (+36 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/magic-link/index.ts` (+11 -5) 📝 `packages/better-auth/src/plugins/magic-link/magic-link.test.ts` (+2 -2) 📝 `packages/better-auth/src/plugins/mcp/authorize.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/mcp/index.ts` (+3 -3) 📝 `packages/better-auth/src/plugins/oidc-provider/authorize.ts` (+1 -1) 📝 `packages/better-auth/src/plugins/oidc-provider/index.ts` (+7 -7) 📝 `packages/better-auth/src/plugins/phone-number/routes.ts` (+11 -11) </details> ### 📄 Description ## Summary Follow-up to #7600 — extends the `magic-link:` prefix pattern to all plugins that store data in the shared `verification` table without a meaningful prefix. - **magic-link**: adds `magic-link:${token}` prefix with backward-compatibility fallback for tokens stored before this change - **phone-number**: adds `phone-number:${phoneNumber}` prefix (basic OTP) and `phone-number:${phoneNumber}:request-password-reset` (password reset OTP) - **oidc-provider**: adds `oidc-code:${code}` prefix for authorization codes (both initial store and consent-flow update) - **mcp**: adds `mcp-code:${code}` prefix for authorization codes Already had prefixes (no changes needed): `one-time-token:`, `siwe:`, `email-verification-otp-`/dynamic OTP prefixes, `2fa-otp-`, `trust-device-`, `reset-password:`, `2fa-`. ## Test plan - [x] All existing magic-link tests pass (16 tests) - [x] All existing phone-number tests pass (26 tests) - [x] All existing oidc-provider tests pass (35 tests) - [x] All existing mcp tests pass (36 tests) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:52:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7895
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?