github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8208] [MERGED] test(scim): split scim.test.ts to fix CI flaky timeout #7819

New Issue
Closed
opened 2026-03-13 13:50:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:50:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8208
Author: @himself65
Created: 2/28/2026
Status: ✅ Merged
Merged: 2/28/2026
Merged by: @himself65

Base: canary ← Head: fix/scim-split-flaky-test

📝 Commits (1)

  • 8280337 test(scim): split scim.test.ts to fix CI flaky timeout

📊 Changes

4 files changed (+1482 additions, -1269 deletions)

View changed files

➕ packages/scim/src/scim-patch.test.ts (+721 -0)
➕ packages/scim/src/scim-users.test.ts (+760 -0)
📝 packages/scim/src/scim.test.ts (+0 -1269)
📝 packages/scim/vitest.config.ts (+1 -0)

📄 Description

Summary

  • Split the monolithic scim.test.ts (2357 lines, 54 tests) into 3 smaller files so vitest runs them in separate workers, reducing resource contention that caused intermittent CI timeouts
  • Bumped testTimeout to 10s in packages/scim/vitest.config.ts to handle CI slowness globally
  • scim.test.ts (19 tests): ServiceProviderConfig, Schemas, ResourceTypes, POST/PUT Users
  • scim-patch.test.ts (19 tests): PATCH /scim/v2/users
  • scim-users.test.ts (16 tests): GET/DELETE Users, Default SCIM provider (includes the previously flaky test)

Test plan

  • All 81 SCIM tests pass (pnpm vitest packages/scim/src/ --run)
  • Each file passes independently
  • pnpm lint passes
  • pnpm typecheck passes
  • pnpm format:check passes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8208 **Author:** [@himself65](https://github.com/himself65) **Created:** 2/28/2026 **Status:** ✅ Merged **Merged:** 2/28/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/scim-split-flaky-test` --- ### 📝 Commits (1) - [`8280337`](https://github.com/better-auth/better-auth/commit/828033727e0ef15c64a426a3dad1dcf5e2886b51) test(scim): split scim.test.ts to fix CI flaky timeout ### 📊 Changes **4 files changed** (+1482 additions, -1269 deletions) <details> <summary>View changed files</summary> ➕ `packages/scim/src/scim-patch.test.ts` (+721 -0) ➕ `packages/scim/src/scim-users.test.ts` (+760 -0) 📝 `packages/scim/src/scim.test.ts` (+0 -1269) 📝 `packages/scim/vitest.config.ts` (+1 -0) </details> ### 📄 Description ## Summary - Split the monolithic `scim.test.ts` (2357 lines, 54 tests) into 3 smaller files so vitest runs them in separate workers, reducing resource contention that caused intermittent CI timeouts - Bumped `testTimeout` to 10s in `packages/scim/vitest.config.ts` to handle CI slowness globally - **`scim.test.ts`** (19 tests): ServiceProviderConfig, Schemas, ResourceTypes, POST/PUT Users - **`scim-patch.test.ts`** (19 tests): PATCH /scim/v2/users - **`scim-users.test.ts`** (16 tests): GET/DELETE Users, Default SCIM provider (includes the previously flaky test) ## Test plan - [x] All 81 SCIM tests pass (`pnpm vitest packages/scim/src/ --run`) - [x] Each file passes independently - [x] `pnpm lint` passes - [x] `pnpm typecheck` passes - [x] `pnpm format:check` passes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:50:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7819
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?