github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8207] [CLOSED] fix(landing): remove react-grab/mcp scripts that cause network scanning #7818

New Issue
Closed
opened 2026-03-13 13:50:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:50:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8207
Author: @himself65
Created: 2/28/2026
Status: ❌ Closed

Base: canary ← Head: fix/remove-react-grab-mcp-scripts

📝 Commits (1)

  • be13a60 fix(landing): remove react-grab/mcp scripts that cause network scanning

📊 Changes

2 files changed (+0 additions, -21 deletions)

View changed files

📝 landing/app/layout.tsx (+0 -20)
📝 landing/package.json (+0 -1)

📄 Description

Summary

  • Removed react-grab and @react-grab/mcp script tags from landing/app/layout.tsx that were causing local network device discovery/scanning for visitors
  • Removed unused next/script import and @react-grab/mcp devDependency from landing/package.json
  • The scripts used next/script with strategy="beforeInteractive" which injects into server-rendered HTML, potentially leaking past the NODE_ENV === "development" guard into production builds

Test plan

  • Verify the landing page loads correctly in dev (pnpm dev in landing/)
  • Verify no network scanning/device discovery requests in browser DevTools Network tab
  • Confirm production build (pnpm build in landing/) succeeds without errors

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8207 **Author:** [@himself65](https://github.com/himself65) **Created:** 2/28/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `fix/remove-react-grab-mcp-scripts` --- ### 📝 Commits (1) - [`be13a60`](https://github.com/better-auth/better-auth/commit/be13a60f8107f7de8f2d1727f477623c53abea70) fix(landing): remove react-grab/mcp scripts that cause network scanning ### 📊 Changes **2 files changed** (+0 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `landing/app/layout.tsx` (+0 -20) 📝 `landing/package.json` (+0 -1) </details> ### 📄 Description ## Summary - Removed `react-grab` and `@react-grab/mcp` script tags from `landing/app/layout.tsx` that were causing local network device discovery/scanning for visitors - Removed unused `next/script` import and `@react-grab/mcp` devDependency from `landing/package.json` - The scripts used `next/script` with `strategy="beforeInteractive"` which injects into server-rendered HTML, potentially leaking past the `NODE_ENV === "development"` guard into production builds ## Test plan - [ ] Verify the landing page loads correctly in dev (`pnpm dev` in `landing/`) - [ ] Verify no network scanning/device discovery requests in browser DevTools Network tab - [ ] Confirm production build (`pnpm build` in `landing/`) succeeds without errors --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:50:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7818
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?