github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8164] [CLOSED] fix(cli): handle database adapter init failure in generate command #7790

New Issue
Closed
opened 2026-03-13 13:49:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:49:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8164
Author: @himself65
Created: 2/26/2026
Status: ❌ Closed

Base: canary ← Head: fix/cli-deno-generate

📝 Commits (1)

  • c623adf fix(cli): handle database adapter init failure in generate command (#8154)

📊 Changes

1 file changed (+81 additions, -0 deletions)

View changed files

📝 packages/cli/src/commands/generate.ts (+81 -0)

📄 Description

Summary

  • When native database drivers can't be loaded (e.g. better-sqlite3 in Deno), the generate command now creates a fallback adapter from config metadata so Drizzle/Prisma schema generators still work
  • For the Kysely generator (which requires a live DB connection), a clear error message is shown suggesting alternatives (use Drizzle/Prisma adapter, or run the CLI via Node.js)
  • No change in behavior for normal Node.js usage

Closes #8154

Test plan

  • Verified Drizzle schema generation works in Deno with a dialect-based config and fallback adapter
  • Verified Kysely path shows a clear error message instead of an unhandled crash
  • Existing generate.test.ts tests pass (28/28 non-native-dependent tests)
  • pnpm typecheck, pnpm lint, pnpm format:check all pass

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8164 **Author:** [@himself65](https://github.com/himself65) **Created:** 2/26/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `fix/cli-deno-generate` --- ### 📝 Commits (1) - [`c623adf`](https://github.com/better-auth/better-auth/commit/c623adf62a1453250e4569e04254d28a110a52a0) fix(cli): handle database adapter init failure in generate command (#8154) ### 📊 Changes **1 file changed** (+81 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/cli/src/commands/generate.ts` (+81 -0) </details> ### 📄 Description ## Summary - When native database drivers can't be loaded (e.g. `better-sqlite3` in Deno), the `generate` command now creates a fallback adapter from config metadata so Drizzle/Prisma schema generators still work - For the Kysely generator (which requires a live DB connection), a clear error message is shown suggesting alternatives (use Drizzle/Prisma adapter, or run the CLI via Node.js) - No change in behavior for normal Node.js usage Closes #8154 ## Test plan - [x] Verified Drizzle schema generation works in Deno with a dialect-based config and fallback adapter - [x] Verified Kysely path shows a clear error message instead of an unhandled crash - [x] Existing `generate.test.ts` tests pass (28/28 non-native-dependent tests) - [x] `pnpm typecheck`, `pnpm lint`, `pnpm format:check` all pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:49:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7790
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?