github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8090] [MERGED] fix(expo): delete expired cookies instead of storing empty values #7739

New Issue
Closed
opened 2026-03-13 13:47:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:47:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8090
Author: @bytaesu
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @bytaesu

Base: canary ← Head: 2026-02-21/fix/expo-cookie-cleanup

📝 Commits (1)

  • 81146aa fix(expo): delete expired cookies instead of storing empty values

📊 Changes

2 files changed (+37 additions, -13 deletions)

View changed files

📝 packages/expo/src/client.ts (+11 -13)
📝 packages/expo/test/expo.test.ts (+26 -0)

📄 Description

Related to https://github.com/better-auth/better-auth/issues/2493#issuecomment-3923701935

Summary by cubic

Delete expired cookies in the Expo client instead of storing blank values. This prevents stale auth state and avoids sending empty Cookie headers.

  • Bug Fixes
    • Remove cookies when Max-Age ≤ 0 or Expires is in the past.
    • Only attach the Cookie header if a cookie string exists.

Written for commit 81146aa09e. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8090 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@bytaesu](https://github.com/bytaesu) **Base:** `canary` ← **Head:** `2026-02-21/fix/expo-cookie-cleanup` --- ### 📝 Commits (1) - [`81146aa`](https://github.com/better-auth/better-auth/commit/81146aa09e1f73477b0b0623d3375486a0020703) fix(expo): delete expired cookies instead of storing empty values ### 📊 Changes **2 files changed** (+37 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `packages/expo/src/client.ts` (+11 -13) 📝 `packages/expo/test/expo.test.ts` (+26 -0) </details> ### 📄 Description - Closes #2493 Related to https://github.com/better-auth/better-auth/issues/2493#issuecomment-3923701935 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Delete expired cookies in the Expo client instead of storing blank values. This prevents stale auth state and avoids sending empty Cookie headers. - **Bug Fixes** - Remove cookies when Max-Age ≤ 0 or Expires is in the past. - Only attach the Cookie header if a cookie string exists. <sup>Written for commit 81146aa09e1f73477b0b0623d3375486a0020703. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:47:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7739
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?