github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #8069] [MERGED] fix(stripe): inject metadata to schedules on update, not on create #7725

New Issue
Closed
opened 2026-03-13 13:47:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:47:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/8069
Author: @bytaesu
Created: 2/19/2026
Status: ✅ Merged
Merged: 2/19/2026
Merged by: @bytaesu

Base: canary ← Head: 2026-02-20/fix/stripe-schedules-metadata

📝 Commits (2)

  • 3859a6d fix(stripe): inject metadata to schedules on update, not create
  • d6d3e8f Merge branch 'canary' into 2026-02-20/fix/stripe-schedules-metadata

📊 Changes

2 files changed (+2 additions, -3 deletions)

View changed files

📝 packages/stripe/src/routes.ts (+1 -1)
📝 packages/stripe/test/stripe.test.ts (+1 -2)

📄 Description

Note

from_subscription:
When using this parameter, other parameters (such as phase values) cannot be set. To create a subscription schedule with other modifications, we recommend making two separate API calls.
https://docs.stripe.com/api/subscription_schedules/create#create_subscription_schedule-from_subscription

Summary by cubic

Inject Stripe subscription schedule metadata during update, not create, to comply with Stripe’s from_subscription restriction and avoid errors.

  • Bug Fixes
    • Create schedules with only from_subscription.
    • Add metadata on update along with end_behavior and phases.
    • Update tests to expect metadata on update, not create.

Written for commit d6d3e8fe08. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/8069 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 2/19/2026 **Status:** ✅ Merged **Merged:** 2/19/2026 **Merged by:** [@bytaesu](https://github.com/bytaesu) **Base:** `canary` ← **Head:** `2026-02-20/fix/stripe-schedules-metadata` --- ### 📝 Commits (2) - [`3859a6d`](https://github.com/better-auth/better-auth/commit/3859a6d7accea2d471285bb4f84c6b98412a3f0d) fix(stripe): inject metadata to schedules on update, not create - [`d6d3e8f`](https://github.com/better-auth/better-auth/commit/d6d3e8fe089d8f96e21481913d7a33cf159c2aa5) Merge branch 'canary' into 2026-02-20/fix/stripe-schedules-metadata ### 📊 Changes **2 files changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/stripe/src/routes.ts` (+1 -1) 📝 `packages/stripe/test/stripe.test.ts` (+1 -2) </details> ### 📄 Description > [!NOTE] > `from_subscription`: > When using this parameter, other parameters (such as phase values) cannot be set. To create a subscription schedule with other modifications, we recommend making two separate API calls. > https://docs.stripe.com/api/subscription_schedules/create#create_subscription_schedule-from_subscription <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Inject Stripe subscription schedule metadata during update, not create, to comply with Stripe’s from_subscription restriction and avoid errors. - **Bug Fixes** - Create schedules with only from_subscription. - Add metadata on update along with end_behavior and phases. - Update tests to expect metadata on update, not create. <sup>Written for commit d6d3e8fe089d8f96e21481913d7a33cf159c2aa5. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:47:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7725
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?