github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7928] [MERGED] fix(one-tap): remove broken direct FedCM API call and harden prompt lifecycle #7631

New Issue
Closed
opened 2026-03-13 13:43:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:43:38 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7928
Author: @bytaesu
Created: 2/11/2026
Status: ✅ Merged
Merged: 2/12/2026
Merged by: @himself65

Base: canary ← Head: 2026-02-12/fix/one-tap-fedcm-response-type

📝 Commits (4)

  • 1471e86 fix(one-tap): remove broken direct FedCM API call
  • d0b0736 docs: update fedCM related guides
  • 70b4cb9 fix: handle FedCM prompt lifecycle and script load failure
  • 4f0fc4d Merge branch 'canary' into 2026-02-12/fix/one-tap-fedcm-response-type

📊 Changes

2 files changed (+89 additions, -137 deletions)

View changed files

📝 docs/content/docs/plugins/one-tap.mdx (+2 -2)
📝 packages/better-auth/src/plugins/one-tap/client.ts (+87 -135)

📄 Description

Note

the GIS library will call the FedCM APIs behind the scenes...
https://developers.googleblog.com/federated-credential-management-fedcm-migration-for-google-identity-services

...

https://developers.google.com/identity/gsi/web/guides/fedcm-migration
https://developers.google.com/identity/gsi/web/reference/js-reference

Summary by cubic

Fix One Tap + FedCM by relying only on the Google Identity Services (GIS) library, removing the broken direct FedCM call. Prevents double prompts/runtime errors and clarifies FedCM is GIS-managed (not disable-able). Closes #2243.

  • Bug Fixes
    • Ensure a single in-flight request with a boolean guard; removed AbortController usage.
    • Harden prompt lifecycle: handle dismiss, skip, and not-displayed with exponential backoff; notify and resolve on no-retry reasons or after max attempts.
    • Reject with a clear error when the GIS script fails to load.

Written for commit 4f0fc4d341. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7928 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 2/11/2026 **Status:** ✅ Merged **Merged:** 2/12/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `2026-02-12/fix/one-tap-fedcm-response-type` --- ### 📝 Commits (4) - [`1471e86`](https://github.com/better-auth/better-auth/commit/1471e865f1dddcac861ea05b88b3b0aeaee83808) fix(one-tap): remove broken direct FedCM API call - [`d0b0736`](https://github.com/better-auth/better-auth/commit/d0b0736d4671575dffdd683d731cf7f622235eb0) docs: update fedCM related guides - [`70b4cb9`](https://github.com/better-auth/better-auth/commit/70b4cb92606dd9eb2ceb2cc1c14cad4c693528ad) fix: handle FedCM prompt lifecycle and script load failure - [`4f0fc4d`](https://github.com/better-auth/better-auth/commit/4f0fc4d3414dcb17fab48701066050ecb509c0d7) Merge branch 'canary' into 2026-02-12/fix/one-tap-fedcm-response-type ### 📊 Changes **2 files changed** (+89 additions, -137 deletions) <details> <summary>View changed files</summary> 📝 `docs/content/docs/plugins/one-tap.mdx` (+2 -2) 📝 `packages/better-auth/src/plugins/one-tap/client.ts` (+87 -135) </details> ### 📄 Description > [!NOTE] > the GIS library will call the FedCM APIs behind the scenes... > https://developers.googleblog.com/federated-credential-management-fedcm-migration-for-google-identity-services > > ... > > https://developers.google.com/identity/gsi/web/guides/fedcm-migration > https://developers.google.com/identity/gsi/web/reference/js-reference - Closes #2243 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix One Tap + FedCM by relying only on the Google Identity Services (GIS) library, removing the broken direct FedCM call. Prevents double prompts/runtime errors and clarifies FedCM is GIS-managed (not disable-able). Closes #2243. - **Bug Fixes** - Ensure a single in-flight request with a boolean guard; removed AbortController usage. - Harden prompt lifecycle: handle dismiss, skip, and not-displayed with exponential backoff; notify and resolve on no-retry reasons or after max attempts. - Reject with a clear error when the GIS script fails to load. <sup>Written for commit 4f0fc4d3414dcb17fab48701066050ecb509c0d7. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:43:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7631
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?