github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7851] [MERGED] fix(oauth-provider): add missing oauthClient createdAt/updatedAt values #7592

New Issue
Closed
opened 2026-03-13 13:42:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:42:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7851
Author: @dvanmali
Created: 2/8/2026
Status: ✅ Merged
Merged: 2/17/2026
Merged by: @Bekacru

Base: canary ← Head: opIssCleaning

📝 Commits (1)

  • 687c4a7 fix: add missing createdAt and updatedAt values, missing function parameters, move metadata tests from authorize

📊 Changes

7 files changed (+20 additions, -9 deletions)

View changed files

📝 packages/oauth-provider/src/authorize.test.ts (+0 -5)
📝 packages/oauth-provider/src/metadata.test.ts (+2 -0)
📝 packages/oauth-provider/src/oauth.ts (+4 -0)
📝 packages/oauth-provider/src/oauthClient/endpoints.test.ts (+3 -0)
📝 packages/oauth-provider/src/oauthClient/endpoints.ts (+5 -2)
📝 packages/oauth-provider/src/register.test.ts (+1 -1)
📝 packages/oauth-provider/src/register.ts (+5 -1)

📄 Description

Adds missing createdAt and updatedAt values and fixes the metadata endpoint in some configurations.

Summary by cubic

Adds missing createdAt/updatedAt for OAuth clients and completes provider metadata based on config. Fixes the metadata endpoint so it consistently advertises RFC 9207 and rounds timestamps to whole seconds.

  • New Features

    • Metadata now includes public_client_supported, grant_types_supported, jwt_disabled; scopes_supported reflects configured scopes.
    • Advertises authorization_response_iss_parameter_supported; assertions moved to the metadata test suite.

  • Bug Fixes

    • Set createdAt/updatedAt on client creation; update updatedAt on client updates and secret rotation.
    • Use floor-second precision for client_id_issued_at and timestamp conversions to match spec and tests.

Written for commit 687c4a7490. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7851 **Author:** [@dvanmali](https://github.com/dvanmali) **Created:** 2/8/2026 **Status:** ✅ Merged **Merged:** 2/17/2026 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `opIssCleaning` --- ### 📝 Commits (1) - [`687c4a7`](https://github.com/better-auth/better-auth/commit/687c4a749092894e90e0448fbd807f55ee030ba1) fix: add missing createdAt and updatedAt values, missing function parameters, move metadata tests from authorize ### 📊 Changes **7 files changed** (+20 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/oauth-provider/src/authorize.test.ts` (+0 -5) 📝 `packages/oauth-provider/src/metadata.test.ts` (+2 -0) 📝 `packages/oauth-provider/src/oauth.ts` (+4 -0) 📝 `packages/oauth-provider/src/oauthClient/endpoints.test.ts` (+3 -0) 📝 `packages/oauth-provider/src/oauthClient/endpoints.ts` (+5 -2) 📝 `packages/oauth-provider/src/register.test.ts` (+1 -1) 📝 `packages/oauth-provider/src/register.ts` (+5 -1) </details> ### 📄 Description Adds missing `createdAt` and `updatedAt` values and fixes the `metadata` endpoint in some configurations. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Adds missing createdAt/updatedAt for OAuth clients and completes provider metadata based on config. Fixes the metadata endpoint so it consistently advertises RFC 9207 and rounds timestamps to whole seconds. - **New Features** - Metadata now includes public_client_supported, grant_types_supported, jwt_disabled; scopes_supported reflects configured scopes. - Advertises authorization_response_iss_parameter_supported; assertions moved to the metadata test suite. - **Bug Fixes** - Set createdAt/updatedAt on client creation; update updatedAt on client updates and secret rotation. - Use floor-second precision for client_id_issued_at and timestamp conversions to match spec and tests. <sup>Written for commit 687c4a749092894e90e0448fbd807f55ee030ba1. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:42:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7592
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?