github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-08-19 00:52:24 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7765] [CLOSED] fix(expo): make expo-network non-optional #7540

New Issue
Closed
opened 2026-03-13 13:40:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:40:53 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7765
Author: @Bekacru
Created: 2/2/2026
Status: ❌ Closed

Base: canary ← Head: cursor/production-console-logs-ac32

📝 Commits (1)

  • 62c2c72 fix(expo): make expo-network a required peer dependency

📊 Changes

1 file changed (+0 additions, -3 deletions)

View changed files

📝 packages/expo/package.json (+0 -3)

📄 Description

Remove expo-network from peerDependenciesMeta to fix "Unable to resolve module expo-network" errors.

Metro (React Native bundler) attempts to resolve all imports at bundle time, even dynamic ones. Marking expo-network as optional in peerDependenciesMeta while it's always imported in online-manager.ts caused resolution failures if the package wasn't explicitly installed. By removing it from peerDependenciesMeta, it becomes a required peer dependency, ensuring it's always installed.

Slack Thread

Open in Cursor Open in Web

Summary by cubic

Make expo-network a required peer dependency in the Expo package to prevent Metro “Unable to resolve module expo-network” errors. Remove expo-network from peerDependenciesMeta because online-manager always imports it.

Written for commit 62c2c721dd. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7765 **Author:** [@Bekacru](https://github.com/Bekacru) **Created:** 2/2/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `cursor/production-console-logs-ac32` --- ### 📝 Commits (1) - [`62c2c72`](https://github.com/better-auth/better-auth/commit/62c2c721dda35cc7a1ae0eb75a7ae888fd49fe7f) fix(expo): make expo-network a required peer dependency ### 📊 Changes **1 file changed** (+0 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/expo/package.json` (+0 -3) </details> ### 📄 Description Remove `expo-network` from `peerDependenciesMeta` to fix "Unable to resolve module expo-network" errors. Metro (React Native bundler) attempts to resolve all imports at bundle time, even dynamic ones. Marking `expo-network` as optional in `peerDependenciesMeta` while it's always imported in `online-manager.ts` caused resolution failures if the package wasn't explicitly installed. By removing it from `peerDependenciesMeta`, it becomes a required peer dependency, ensuring it's always installed. --- [Slack Thread](https://betterauth.slack.com/archives/C0A8B5BARUK/p1770059765236129?thread_ts=1770059765.236129&cid=C0A8B5BARUK) <a href="https://cursor.com/background-agent?bcId=bc-a4e41e15-8bab-50e7-a1aa-86bb7d510741"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-a4e41e15-8bab-50e7-a1aa-86bb7d510741"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Make expo-network a required peer dependency in the Expo package to prevent Metro “Unable to resolve module expo-network” errors. Remove expo-network from peerDependenciesMeta because online-manager always imports it. <sup>Written for commit 62c2c721dda35cc7a1ae0eb75a7ae888fd49fe7f. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:40:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7540