github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7723] [CLOSED] fix: include haveIBeenPawened error logs #7515

New Issue
Closed
opened 2026-03-13 13:39:59 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:39:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7723
Author: @ping-maxwell
Created: 1/31/2026
Status: ❌ Closed

Base: canary ← Head: fix/include-haveIBeenPawened-error-logs

📝 Commits (1)

  • c168072 fix: include haveIBeenPawened error logs

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/plugins/haveibeenpwned/index.ts (+3 -0)

📄 Description

Summary by cubic

Add server-side logging for failures when checking passwords against the HaveIBeenPwned API. Uses createLogger to record the error before returning a generic INTERNAL_SERVER_ERROR to clients for better observability without leaking details.

Written for commit c168072edd. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7723 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 1/31/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `fix/include-haveIBeenPawened-error-logs` --- ### 📝 Commits (1) - [`c168072`](https://github.com/better-auth/better-auth/commit/c168072edd8d0f68b89689a078c94ca2907e41f7) fix: include haveIBeenPawened error logs ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/haveibeenpwned/index.ts` (+3 -0) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Add server-side logging for failures when checking passwords against the HaveIBeenPwned API. Uses createLogger to record the error before returning a generic INTERNAL_SERVER_ERROR to clients for better observability without leaking details. <sup>Written for commit c168072edd8d0f68b89689a078c94ca2907e41f7. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:39:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7515
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?