github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7679] [CLOSED] chore(CI): Run adapter CI if respective adapter code changes #7490

New Issue
Closed
opened 2026-03-13 13:38:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:38:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7679
Author: @ping-maxwell
Created: 1/29/2026
Status: ❌ Closed

Base: canary ← Head: chore/ci/run-adapter-ci-if-code-changes

📝 Commits (10+)

  • 4935af4 chore(CI): Run adapter CI if respective adapter code changes
  • 0173d14 chore: lint
  • 31f9957 fix: integration tests hang as pending
  • b841d5e fix: still hanging for some reason
  • 8b675fd Update e2e.yml
  • dbab307 Update e2e.yml
  • 98db4fc Update e2e.yml
  • e77cad5 move to it's own file
  • 74c8489 Merge branch 'canary' into chore/ci/run-adapter-ci-if-code-changes
  • 535e455 test: should run drizzle tests

📊 Changes

2 files changed (+331 additions, -65 deletions)

View changed files

➕ .github/workflows/adapter.yml (+326 -0)
📝 .github/workflows/e2e.yml (+5 -65)

📄 Description

Updated the adapter-integration job in the workflow to run adapter integration tests only when the corresponding adapter package changes.

  • @better-auth-test/adapter-factory → packages/core/src/db/adapter/**
  • @better-auth-test/drizzle-adapter → packages/drizzle-adapter/**
  • @better-auth-test/kysely-prisma-adapter → packages/kysely-adapter/**
  • @better-auth-test/memory-adapter → packages/memory-adapter/**
  • @better-auth-test/mongo-adapter → packages/mongo-adapter/**
  • @better-auth-test/prisma-adapter → packages/prisma-adapter/**

Summary by cubic

Run adapter integration tests only when the relevant adapter code changes. This cuts CI time and fixes merge queue jobs hanging as pending.

  • Refactors

    • Replaced static matrix with a package-to-path mapping for each adapter.
    • Added change detection to run tests only when matching paths change.
    • Adapter-factory also runs on packages/core changes.
    • Gated cache, setup, Docker, and test steps behind the change check.
    • Moved adapter integration to its own workflow file.

  • Bug Fixes

    • Skip adapter-integration in merge queue to prevent pending jobs.

Written for commit 82c6cb2113. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7679 **Author:** [@ping-maxwell](https://github.com/ping-maxwell) **Created:** 1/29/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `chore/ci/run-adapter-ci-if-code-changes` --- ### 📝 Commits (10+) - [`4935af4`](https://github.com/better-auth/better-auth/commit/4935af4a513fbde88860d06a0557d3e6bd772073) chore(CI): Run adapter CI if respective adapter code changes - [`0173d14`](https://github.com/better-auth/better-auth/commit/0173d14ec5db250a00c1b9a4e655ed0bbd075cc8) chore: lint - [`31f9957`](https://github.com/better-auth/better-auth/commit/31f995782ce9a36da21368f2c91045f741bde825) fix: integration tests hang as pending - [`b841d5e`](https://github.com/better-auth/better-auth/commit/b841d5e2e9cd3bba20979dc93a8be92a5426475c) fix: still hanging for some reason - [`8b675fd`](https://github.com/better-auth/better-auth/commit/8b675fd52838f00c70511e1fab46aa1f88d769d4) Update e2e.yml - [`dbab307`](https://github.com/better-auth/better-auth/commit/dbab3074536be4e4797217c1d728b4afd9524a34) Update e2e.yml - [`98db4fc`](https://github.com/better-auth/better-auth/commit/98db4fc6bf154bdba5d08aa9526319d7427d2f5b) Update e2e.yml - [`e77cad5`](https://github.com/better-auth/better-auth/commit/e77cad5042e44495cbfe326c6e7fd438c5659088) move to it's own file - [`74c8489`](https://github.com/better-auth/better-auth/commit/74c848992d1cea17386a009612440db24f0faa61) Merge branch 'canary' into chore/ci/run-adapter-ci-if-code-changes - [`535e455`](https://github.com/better-auth/better-auth/commit/535e45540c21b3813a46d644aa5d1b07de4c0b40) test: should run drizzle tests ### 📊 Changes **2 files changed** (+331 additions, -65 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/adapter.yml` (+326 -0) 📝 `.github/workflows/e2e.yml` (+5 -65) </details> ### 📄 Description Updated the adapter-integration job in the workflow to run adapter integration tests only when the corresponding adapter package changes. - `@better-auth-test/adapter-factory` → `packages/core/src/db/adapter/**` - `@better-auth-test/drizzle-adapter` → `packages/drizzle-adapter/**` - `@better-auth-test/kysely-prisma-adapter` → `packages/kysely-adapter/**` - `@better-auth-test/memory-adapter` → `packages/memory-adapter/**` - `@better-auth-test/mongo-adapter` → `packages/mongo-adapter/**` - `@better-auth-test/prisma-adapter` → `packages/prisma-adapter/**` <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Run adapter integration tests only when the relevant adapter code changes. This cuts CI time and fixes merge queue jobs hanging as pending. - **Refactors** - Replaced static matrix with a package-to-path mapping for each adapter. - Added change detection to run tests only when matching paths change. - Adapter-factory also runs on packages/core changes. - Gated cache, setup, Docker, and test steps behind the change check. - Moved adapter integration to its own workflow file. - **Bug Fixes** - Skip adapter-integration in merge queue to prevent pending jobs. <sup>Written for commit 82c6cb211303d658f4cdd4a15657e9cf86834daf. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:38:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7490
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?