github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

Plugin: Passkey - Signin callback doesn't exist #748

New Issue
Closed
opened 2026-03-13 08:02:43 -05:00 by GiteaMirror · 6 comments
GiteaMirror commented 2026-03-13 08:02:43 -05:00
Owner
Copy Link

Originally created by @char-ptr on GitHub (Feb 27, 2025).

Is this suited for github?

  • Yes, this is suited for github

To Reproduce

  1. setup better auth to use passkeys
  2. make signin page
  3. attempt to use passkeys to signin and add a callback url

Current vs. Expected behavior

current: authClient.signIn.passkey function does not have a param to accept callback url
expected: authClient.signIn.passkey function does has param to accept callback url

What version of Better Auth are you using?

1.1.21

Provide environment information

- OS: Windows 10
- Browser: Firefox

Which area(s) are affected? (Select all that apply)

Documentation, Client

Auth config (if applicable)

import { betterAuth } from "better-auth"
import { passkey } from "better-auth/plugins/passkey"

export const auth = betterAuth({
   plugins: [
    passkey(),
  ]
});
// client
import { createAuthClient } from "better-auth/react"
import { passkeyClient } from "better-auth/client/plugins"
const authClient = createAuthClient({
  baseURL: "https://localhost:3000",
  plugins: [
    passkeyClient()
  ]
})

Additional context

In documentation it specifies that there should be a callback field, yet there is no such field:
https://github.com/better-auth/better-auth/blob/main/packages/better-auth/src/plugins/passkey/client.ts#L27-L32
Image

Originally created by @char-ptr on GitHub (Feb 27, 2025). ### Is this suited for github? - [x] Yes, this is suited for github ### To Reproduce 1. setup better auth to use passkeys 2. make signin page 3. attempt to use passkeys to signin and add a callback url ### Current vs. Expected behavior current: `authClient.signIn.passkey` function does not have a param to accept callback url expected: `authClient.signIn.passkey` function does has param to accept callback url ### What version of Better Auth are you using? 1.1.21 ### Provide environment information ```bash - OS: Windows 10 - Browser: Firefox ``` ### Which area(s) are affected? (Select all that apply) Documentation, Client ### Auth config (if applicable) ```typescript import { betterAuth } from "better-auth" import { passkey } from "better-auth/plugins/passkey" export const auth = betterAuth({ plugins: [ passkey(), ] }); // client import { createAuthClient } from "better-auth/react" import { passkeyClient } from "better-auth/client/plugins" const authClient = createAuthClient({ baseURL: "https://localhost:3000", plugins: [ passkeyClient() ] }) ``` ### Additional context In documentation it specifies that there should be a callback field, yet there is no such field: https://github.com/better-auth/better-auth/blob/main/packages/better-auth/src/plugins/passkey/client.ts#L27-L32 ![Image](https://github.com/user-attachments/assets/73e54f97-ecfd-41e0-856f-76a85bb233ae) - https://better-auth.vercel.app/docs/plugins/passkey#signin-with-a-passkey
GiteaMirror added the bug label 2026-03-13 08:02:43 -05:00
GiteaMirror commented 2026-03-13 08:02:44 -05:00
Author
Owner
Copy Link

@codedusting commented on GitHub (Mar 3, 2025):

It also doesn't work without registration and registration gives "SESSION_IS_NOT_FRESH" error. I think this passkey feature is broken?

@codedusting commented on GitHub (Mar 3, 2025): It also doesn't work without registration and registration gives "SESSION_IS_NOT_FRESH" error. I think this passkey feature is broken?
GiteaMirror commented 2026-03-13 08:02:44 -05:00
Author
Owner
Copy Link

@codedusting commented on GitHub (Mar 22, 2025):

It also doesn't work without registration and registration gives "SESSION_IS_NOT_FRESH" error. I think this passkey feature is broken?

Is there any way around for the above?

@codedusting commented on GitHub (Mar 22, 2025): > It also doesn't work without registration and registration gives "SESSION_IS_NOT_FRESH" error. I think this passkey feature is broken? Is there any way around for the above?
GiteaMirror commented 2026-03-13 08:02:45 -05:00
Author
Owner
Copy Link

@DimitarY commented on GitHub (Mar 28, 2025):

It also doesn't work without registration and registration gives "SESSION_IS_NOT_FRESH" error. I think this passkey feature is broken?

Is there any way around for the above?

You need to disable the freshAge on the session or you need to refresh the current session

https://www.better-auth.com/docs/concepts/session-management#session-freshness

@DimitarY commented on GitHub (Mar 28, 2025): > > It also doesn't work without registration and registration gives "SESSION_IS_NOT_FRESH" error. I think this passkey feature is broken? > > Is there any way around for the above? You need to disable the freshAge on the session or you need to refresh the current session https://www.better-auth.com/docs/concepts/session-management#session-freshness
GiteaMirror commented 2026-03-13 08:02:45 -05:00
Author
Owner
Copy Link

@DimitarY commented on GitHub (Mar 28, 2025):

I tested the passkey on v1.2.5 and it is still missing the callbackURL as described in docs
https://www.better-auth.com/docs/plugins/passkey#signin-with-a-passkey

Also, I found that when user sign-in with passskey the current page is not updated and only when user manually refresh the page content is updated and user is signed in.

@DimitarY commented on GitHub (Mar 28, 2025): I tested the passkey on v1.2.5 and it is still missing the callbackURL as described in docs https://www.better-auth.com/docs/plugins/passkey#signin-with-a-passkey Also, I found that when user sign-in with passskey the current page is not updated and only when user manually refresh the page content is updated and user is signed in.
GiteaMirror commented 2026-03-13 08:02:46 -05:00
Author
Owner
Copy Link

@jim-y commented on GitHub (Mar 30, 2025):

For the time-being you can use the onSuccess callback and do a manual redirect/route as:

void authClient.signIn.passkey(
	{
		autoFill: true,
		email
	},
	{
		onSuccess: () => {
			if (this.redirectTo) {
				window.location.href = this.redirectTo;
			} else {
				void this.router.navigate(['/user/profile']);
			}
		}
	}
);
@jim-y commented on GitHub (Mar 30, 2025): For the time-being you can use the onSuccess callback and do a manual redirect/route as: ```ts void authClient.signIn.passkey( { autoFill: true, email }, { onSuccess: () => { if (this.redirectTo) { window.location.href = this.redirectTo; } else { void this.router.navigate(['/user/profile']); } } } ); ```
GiteaMirror commented 2026-03-13 08:02:46 -05:00
Author
Owner
Copy Link

@leavism commented on GitHub (Apr 26, 2025):

Also, I found that when user sign-in with passskey the current page is not updated and only when user manually refresh the page content is updated and user is signed in.

I was able to get around that by doing a router refresh:

void (await authClient.signIn.passkey({
	fetchOptions: {
		onSuccess: () => {
			router.push("/");
			router.refresh();
		},
	},
@leavism commented on GitHub (Apr 26, 2025): > Also, I found that when user sign-in with passskey the current page is not updated and only when user manually refresh the page content is updated and user is signed in. I was able to get around that by doing a router refresh: ```ts void (await authClient.signIn.passkey({ fetchOptions: { onSuccess: () => { router.push("/"); router.refresh(); }, }, ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#748
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?