github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-26 08:56:40 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7663] [CLOSED] fix(sso): remove direct better-call runtime dependency #7476

New Issue
Closed
opened 2026-03-13 13:38:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:38:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7663
Author: @bytaesu
Created: 1/28/2026
Status: ❌ Closed

Base: canary ← Head: 2026-01-28/fix/sso-remove-better-call-dep

📝 Commits (1)

  • d0b619e fix(sso): remove direct better-call dependency

📊 Changes

4 files changed (+2 additions, -7 deletions)

View changed files

📝 knip.jsonc (+1 -2)
📝 packages/sso/package.json (+0 -1)
📝 packages/sso/src/saml-state.ts (+1 -1)
📝 pnpm-lock.yaml (+0 -3)

📄 Description

Summary by cubic

Removes the direct better-call dependency from the SSO package and uses APIError from better-auth instead. This simplifies runtime dependencies and avoids shipping better-call.

  • Dependencies
    • Removed better-call from packages/sso/package.json and pnpm-lock.
    • Switched APIError import in saml-state.ts to better-auth/api.
    • Updated knip.jsonc to stop ignoring better-call.

Written for commit d0b619e6c4. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7663 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 1/28/2026 **Status:** ❌ Closed **Base:** `canary` ← **Head:** `2026-01-28/fix/sso-remove-better-call-dep` --- ### 📝 Commits (1) - [`d0b619e`](https://github.com/better-auth/better-auth/commit/d0b619e6c478341ba2433601fd28b83d5d4f234c) fix(sso): remove direct better-call dependency ### 📊 Changes **4 files changed** (+2 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `knip.jsonc` (+1 -2) 📝 `packages/sso/package.json` (+0 -1) 📝 `packages/sso/src/saml-state.ts` (+1 -1) 📝 `pnpm-lock.yaml` (+0 -3) </details> ### 📄 Description - Closes https://github.com/better-auth/better-auth/issues/7219 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Removes the direct better-call dependency from the SSO package and uses APIError from better-auth instead. This simplifies runtime dependencies and avoids shipping better-call. - **Dependencies** - Removed better-call from packages/sso/package.json and pnpm-lock. - Switched APIError import in saml-state.ts to better-auth/api. - Updated knip.jsonc to stop ignoring better-call. <sup>Written for commit d0b619e6c478341ba2433601fd28b83d5d4f234c. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:38:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7476
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?