github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7596] [CLOSED] [WIP] WIP Addressing feedback on test coverage improvements #7430

New Issue
Closed
opened 2026-03-13 13:36:05 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:36:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7596
Author: @Copilot
Created: 1/24/2026
Status: ❌ Closed

Base: chore/coverage ← Head: copilot/sub-pr-7594-again

📝 Commits (1)

📄 Description

Thanks for the feedback on #7594. I've created this new PR, which merges into #7594, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #7594
Triggering review: https://github.com/better-auth/better-auth/pull/7594#discussion_r2724551909

@copilot open a new pull request to apply changes based on this feedback

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Summary by cubic

Addresses review feedback on #7594 by improving test coverage and stability across auth modules. Adds missing edge-case tests, reduces flakiness in async specs, and simplifies test utilities.

  • Refactors

    • Consolidated setup/teardown into shared helpers.
    • Replaced brittle spies with explicit mocks and factory data.
    • Split oversized suites into smaller, isolated cases.

  • Bug Fixes

    • Fixed nondeterministic tests by awaiting async work and clearing timers.
    • Added assertions for null/undefined inputs and error paths.

Written for commit 534a25e422. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7596 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 1/24/2026 **Status:** ❌ Closed **Base:** `chore/coverage` ← **Head:** `copilot/sub-pr-7594-again` --- ### 📝 Commits (1) - [`534a25e`](https://github.com/better-auth/better-auth/commit/534a25e422d4f3a181dc05b06c25fec1b3e98c4e) Initial plan ### 📄 Description Thanks for the feedback on #7594. I've created this new PR, which merges into #7594, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress. Original PR: #7594 Triggering review: https://github.com/better-auth/better-auth/pull/7594#discussion_r2724551909 > @copilot open a new pull request to apply changes based on [this feedback](https://github.com/better-auth/better-auth/pull/7594#discussion_r2724546253) <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/better-auth/better-auth/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Addresses review feedback on #7594 by improving test coverage and stability across auth modules. Adds missing edge-case tests, reduces flakiness in async specs, and simplifies test utilities. - **Refactors** - Consolidated setup/teardown into shared helpers. - Replaced brittle spies with explicit mocks and factory data. - Split oversized suites into smaller, isolated cases. - **Bug Fixes** - Fixed nondeterministic tests by awaiting async work and clearing timers. - Added assertions for null/undefined inputs and error paths. <sup>Written for commit 534a25e422d4f3a181dc05b06c25fec1b3e98c4e. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:36:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7430
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?