github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7555] [MERGED] fix(expo): prevent null cookie key when redirect URL has no cookie param #7396

New Issue
Closed
opened 2026-03-13 13:34:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:34:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7555
Author: @bytaesu
Created: 1/22/2026
Status: ✅ Merged
Merged: 1/22/2026
Merged by: @himself65

Base: canary ← Head: 2026-01-23/fix/expo-null-cookie-key

📝 Commits (2)

  • 66031c8 fix(expo): prevent null cookie key when redirect URL has no cookie param
  • 348d11c chore: clean up unused await

📊 Changes

2 files changed (+44 additions, -6 deletions)

View changed files

📝 packages/expo/src/client.ts (+6 -6)
📝 packages/expo/test/expo.test.ts (+38 -0)

📄 Description

Fixes: https://github.com/better-auth/better-auth/issues/6810

Summary by cubic

Fix Expo client to ignore missing cookie param in OAuth redirect URLs. Prevents writing a "null" cookie key and preserves the current session cookie.

Written for commit 348d11c163. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7555 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 1/22/2026 **Status:** ✅ Merged **Merged:** 1/22/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `2026-01-23/fix/expo-null-cookie-key` --- ### 📝 Commits (2) - [`66031c8`](https://github.com/better-auth/better-auth/commit/66031c8ba92cd939a31cda8fd0e5ab302a054070) fix(expo): prevent null cookie key when redirect URL has no cookie param - [`348d11c`](https://github.com/better-auth/better-auth/commit/348d11c1632575a88675b8b2d6ab50b198d22d47) chore: clean up unused await ### 📊 Changes **2 files changed** (+44 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/expo/src/client.ts` (+6 -6) 📝 `packages/expo/test/expo.test.ts` (+38 -0) </details> ### 📄 Description Fixes: https://github.com/better-auth/better-auth/issues/6810 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix Expo client to ignore missing cookie param in OAuth redirect URLs. Prevents writing a "null" cookie key and preserves the current session cookie. <sup>Written for commit 348d11c1632575a88675b8b2d6ab50b198d22d47. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:34:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7396
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?