github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7488] [MERGED] chore(sso): remove unused ascEndpoint params schema #7350

New Issue
Closed
opened 2026-03-13 13:33:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:33:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7488
Author: @bytaesu
Created: 1/20/2026
Status: ✅ Merged
Merged: 1/20/2026
Merged by: @himself65

Base: canary ← Head: 2026-01-20/fix/sso-unused-params

📝 Commits (1)

  • d471baf fix: remove unused ascEndpoint params schema

📊 Changes

1 file changed (+1 additions, -6 deletions)

View changed files

📝 packages/sso/src/routes/sso.ts (+1 -6)

📄 Description

If it's optional, it won't match the router in the first place and becomes dead code, so it's not a breaking change.

Summary by cubic

Cleaned up SAML ACS routing by removing the optional params schema and the 'sso' providerId fallback. The route now relies only on the path param, with no functional change.

Written for commit d471baf4de. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7488 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 1/20/2026 **Status:** ✅ Merged **Merged:** 1/20/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `2026-01-20/fix/sso-unused-params` --- ### 📝 Commits (1) - [`d471baf`](https://github.com/better-auth/better-auth/commit/d471baf4de57750d78cbc850412a28db691ea8f6) fix: remove unused ascEndpoint params schema ### 📊 Changes **1 file changed** (+1 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/sso/src/routes/sso.ts` (+1 -6) </details> ### 📄 Description If it's optional, it won't match the router in the first place and becomes dead code, so it's not a breaking change. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Cleaned up SAML ACS routing by removing the optional params schema and the 'sso' providerId fallback. The route now relies only on the path param, with no functional change. <sup>Written for commit d471baf4de57750d78cbc850412a28db691ea8f6. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:33:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7350
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?