github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7474] [MERGED] fix: handle serial and false cases in generateId #7337

New Issue
Closed
opened 2026-03-13 13:32:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:32:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7474
Author: @bytaesu
Created: 1/19/2026
Status: ✅ Merged
Merged: 1/20/2026
Merged by: @himself65

Base: canary ← Head: 2026-01-20/fix/handling-generate-id

📝 Commits (3)

  • 7f5a2f8 fix: handle serial and false cases in generateId
  • 2d241f1 fix: handle context generateId false case
  • 5cdabbe fix: just use logical OR fallback

📊 Changes

3 files changed (+52 additions, -6 deletions)

View changed files

📝 packages/better-auth/src/context/create-context.test.ts (+39 -0)
📝 packages/better-auth/src/context/create-context.ts (+9 -2)
📝 packages/better-auth/src/plugins/api-key/routes/create-api-key.ts (+4 -4)

📄 Description

Summary by cubic

Fix generateId to respect database config: 'uuid' returns a UUID; 'serial' or false return false so the DB assigns IDs. Update API key creation to fall back when generateId returns false, and add tests for these cases.

Written for commit 5cdabbe5cf. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7474 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 1/19/2026 **Status:** ✅ Merged **Merged:** 1/20/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `2026-01-20/fix/handling-generate-id` --- ### 📝 Commits (3) - [`7f5a2f8`](https://github.com/better-auth/better-auth/commit/7f5a2f85064f9b5e35e67e5a0f6aa3930a882f3d) fix: handle serial and false cases in generateId - [`2d241f1`](https://github.com/better-auth/better-auth/commit/2d241f19415a5498cd042a4038e9355844123dae) fix: handle context generateId false case - [`5cdabbe`](https://github.com/better-auth/better-auth/commit/5cdabbe5cf0356196fc07df7caa4ac83a322efdc) fix: just use logical OR fallback ### 📊 Changes **3 files changed** (+52 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/context/create-context.test.ts` (+39 -0) 📝 `packages/better-auth/src/context/create-context.ts` (+9 -2) 📝 `packages/better-auth/src/plugins/api-key/routes/create-api-key.ts` (+4 -4) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Fix generateId to respect database config: 'uuid' returns a UUID; 'serial' or false return false so the DB assigns IDs. Update API key creation to fall back when generateId returns false, and add tests for these cases. <sup>Written for commit 5cdabbe5cf0356196fc07df7caa4ac83a322efdc. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:32:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7337
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?