github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 23:52:05 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7280] fix issue: after oidc client successfully signin use better-auth oaut… #7194

New Issue
Open
opened 2026-03-13 13:27:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:27:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7280
Author: @lebrosoft
Created: 1/12/2026
Status: 🔄 Open

Base: canary ← Head: canary

📝 Commits (1)

  • 0867f4b fix issue: after oidc client successfully signin use better-auth oauth provider authorization server, user cant be redirected back to oidc client page due to error: xxx been blocked by CORS policy: The value of the 'Access-Control-Allow-Credentials' header in the response is '' which must be 'true' when the request's credentials mode is 'include'.

📊 Changes

1 file changed (+11 additions, -4 deletions)

View changed files

📝 packages/oauth-provider/src/client.ts (+11 -4)

📄 Description

fix issue: after oidc client successfully signin use better-auth oauth provider authorization server, user cant be redirected back to oidc client page due to error: xxx been blocked by CORS policy: The value of the 'Access-Control-Allow-Credentials' header in the response is '' which must be 'true' when the request's credentials mode is 'include'.

may related issue link

Summary by cubic

Fix redirect after OIDC sign-in with the better-auth OAuth provider by forcing JSON responses during the OAuth flow. This prevents CORS credential errors and lets the client handle redirects safely.

  • Bug Fixes
    • Send Accept: application/json when oauth_query is present on /oauth2/consent and /oauth2/continue.
    • Pass parsed oauth_query in the response body for the client to process signed query params.

Written for commit 0867f4bb09. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7280 **Author:** [@lebrosoft](https://github.com/lebrosoft) **Created:** 1/12/2026 **Status:** 🔄 Open **Base:** `canary` ← **Head:** `canary` --- ### 📝 Commits (1) - [`0867f4b`](https://github.com/better-auth/better-auth/commit/0867f4bb09278ff75c187c61a5a2a1072a63499a) fix issue: after oidc client successfully signin use better-auth oauth provider authorization server, user cant be redirected back to oidc client page due to error: xxx been blocked by CORS policy: The value of the 'Access-Control-Allow-Credentials' header in the response is '' which must be 'true' when the request's credentials mode is 'include'. ### 📊 Changes **1 file changed** (+11 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/oauth-provider/src/client.ts` (+11 -4) </details> ### 📄 Description fix issue: after oidc client successfully signin use better-auth oauth provider authorization server, user cant be redirected back to oidc client page due to error: xxx been blocked by CORS policy: The value of the 'Access-Control-Allow-Credentials' header in the response is '' which must be 'true' when the request's credentials mode is 'include'. [may related issue link](https://github.com/better-auth/better-auth/issues/7041) <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix redirect after OIDC sign-in with the better-auth OAuth provider by forcing JSON responses during the OAuth flow. This prevents CORS credential errors and lets the client handle redirects safely. - **Bug Fixes** - Send Accept: application/json when oauth_query is present on /oauth2/consent and /oauth2/continue. - Pass parsed oauth_query in the response body for the client to process signed query params. <sup>Written for commit 0867f4bb09278ff75c187c61a5a2a1072a63499a. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:27:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7194
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?