github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7232] [MERGED] fix(oauth-provider): properly handle metadata field in client registration #7163

New Issue
Closed
opened 2026-03-13 13:26:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:26:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7232
Author: @Paola3stefania
Created: 1/9/2026
Status: ✅ Merged
Merged: 1/10/2026
Merged by: @himself65

Base: canary ← Head: fix/oauth-provider-metadata-json-parse

📝 Commits (3)

  • 2a71111 fix: better handle metadata in client registration
  • faeba8a male lint happy
  • 47347d2 fix: helper function

📊 Changes

5 files changed (+66 additions, -8 deletions)

View changed files

📝 packages/oauth-provider/src/introspect.ts (+2 -1)
📝 packages/oauth-provider/src/register.test.ts (+35 -0)
📝 packages/oauth-provider/src/register.ts (+12 -4)
📝 packages/oauth-provider/src/token.ts (+4 -3)
📝 packages/oauth-provider/src/utils/index.ts (+13 -0)

📄 Description

Closes https://github.com/better-auth/better-auth/issues/7135

Summary by cubic

Fix metadata handling in OAuth client registration and token flows. Metadata can be sent as an object or string, is merged with extra fields, serialized once, and safely parsed; registration responses now spread metadata fields at the top level.

  • Bug Fixes
    • Accept metadata as object or string; merge with extra fields and serialize in register.ts.
    • Safely parse metadata in token, ID token, introspection, and client credentials flows.
    • Add tests verifying registration with metadata and extra fields, and that response spreads metadata fields.

Written for commit 47347d2b09. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7232 **Author:** [@Paola3stefania](https://github.com/Paola3stefania) **Created:** 1/9/2026 **Status:** ✅ Merged **Merged:** 1/10/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/oauth-provider-metadata-json-parse` --- ### 📝 Commits (3) - [`2a71111`](https://github.com/better-auth/better-auth/commit/2a711115d963e25060181bc7bd20f9a6283b82b0) fix: better handle metadata in client registration - [`faeba8a`](https://github.com/better-auth/better-auth/commit/faeba8aafd5047e4e4bc47c0a0ae999bd310a641) male lint happy - [`47347d2`](https://github.com/better-auth/better-auth/commit/47347d2b09ec569cace47f4304dbe504d7be5d81) fix: helper function ### 📊 Changes **5 files changed** (+66 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `packages/oauth-provider/src/introspect.ts` (+2 -1) 📝 `packages/oauth-provider/src/register.test.ts` (+35 -0) 📝 `packages/oauth-provider/src/register.ts` (+12 -4) 📝 `packages/oauth-provider/src/token.ts` (+4 -3) 📝 `packages/oauth-provider/src/utils/index.ts` (+13 -0) </details> ### 📄 Description Closes https://github.com/better-auth/better-auth/issues/7135 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix metadata handling in OAuth client registration and token flows. Metadata can be sent as an object or string, is merged with extra fields, serialized once, and safely parsed; registration responses now spread metadata fields at the top level. - **Bug Fixes** - Accept metadata as object or string; merge with extra fields and serialize in register.ts. - Safely parse metadata in token, ID token, introspection, and client credentials flows. - Add tests verifying registration with metadata and extra fields, and that response spreads metadata fields. <sup>Written for commit 47347d2b09ec569cace47f4304dbe504d7be5d81. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:26:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7163
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?