github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 14:21:55 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7225] [MERGED] chore: op plugin test fail #7157

New Issue
Closed
opened 2026-03-13 13:26:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:26:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7225
Author: @dvanmali
Created: 1/9/2026
Status: ✅ Merged
Merged: 1/9/2026
Merged by: @himself65

Base: canary ← Head: opPluginTestFail

📝 Commits (1)

  • 7c40835 chore: op plugin test fail

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 packages/oauth-provider/src/utils/index.ts (+5 -1)

📄 Description

Revert breaking change preventing failure when plugin is undefined when it should be.

Fixes the failing test in oauth.test.ts

Summary by cubic

Make getJwtPlugin throw a BetterAuthError when the jwt plugin is missing, restoring fail-fast behavior. This surfaces misconfiguration early and fixes tests that expect failure.

Written for commit 7c4083542d. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7225 **Author:** [@dvanmali](https://github.com/dvanmali) **Created:** 1/9/2026 **Status:** ✅ Merged **Merged:** 1/9/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `opPluginTestFail` --- ### 📝 Commits (1) - [`7c40835`](https://github.com/better-auth/better-auth/commit/7c4083542d95c62de98979ddf834eeb38f6fb497) chore: op plugin test fail ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/oauth-provider/src/utils/index.ts` (+5 -1) </details> ### 📄 Description Revert breaking change preventing failure when plugin is undefined when it should be. Fixes the failing test in `oauth.test.ts` <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Make getJwtPlugin throw a BetterAuthError when the jwt plugin is missing, restoring fail-fast behavior. This surfaces misconfiguration early and fixes tests that expect failure. <sup>Written for commit 7c4083542d95c62de98979ddf834eeb38f6fb497. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:26:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7157
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?