github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7182] [MERGED] fix(session): skip invalid sessions in list #7127

New Issue
Closed
opened 2026-03-13 13:25:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:25:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7182
Author: @Paola3stefania
Created: 1/7/2026
Status: ✅ Merged
Merged: 1/26/2026
Merged by: @Paola3stefania

Base: canary ← Head: fix/session-skip-invalid-sessions

📝 Commits (10+)

  • 8bd95e5 fix: skip invalid session data
  • 3844143 make spell happy
  • 92d4e9e Merge branch 'canary' into fix/session-skip-invalid-sessions
  • 763de01 Merge branch 'canary' into fix/session-skip-invalid-sessions
  • a618d07 Merge branch 'canary' into fix/session-skip-invalid-sessions
  • b017bb5 fix test and types
  • d7d67c5 make lint happy
  • b7e2e0c fix test
  • 59c199b Merge branch 'canary' into fix/session-skip-invalid-sessions
  • 73790ce fix: use DatabaseSync

📊 Changes

4 files changed (+272 additions, -33 deletions)

View changed files

📝 packages/better-auth/src/db/internal-adapter.test.ts (+224 -0)
📝 packages/better-auth/src/db/internal-adapter.ts (+46 -31)
📝 packages/better-auth/src/plugins/jwt/jwt.test.ts (+1 -1)
📝 packages/scim/src/scim.test.ts (+1 -1)

📄 Description

Summary by cubic

Make session listing resilient by skipping invalid or missing sessions in secondary storage. Prevents empty results when one bad session is present.

  • Bug Fixes
    • listSessions now ignores missing, malformed, or corrupt entries instead of clearing the list.
    • findSessions now skips invalid or corrupt session data and returns only valid sessions.
    • Added tests for missing, malformed, corrupt, and all-invalid scenarios.

Written for commit fcec8e49d6. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7182 **Author:** [@Paola3stefania](https://github.com/Paola3stefania) **Created:** 1/7/2026 **Status:** ✅ Merged **Merged:** 1/26/2026 **Merged by:** [@Paola3stefania](https://github.com/Paola3stefania) **Base:** `canary` ← **Head:** `fix/session-skip-invalid-sessions` --- ### 📝 Commits (10+) - [`8bd95e5`](https://github.com/better-auth/better-auth/commit/8bd95e54f6d8c08ee8c2631c5bea4395aecb998f) fix: skip invalid session data - [`3844143`](https://github.com/better-auth/better-auth/commit/3844143cc169dc3ff5ff9fe0ff744b069a53f1b0) make spell happy - [`92d4e9e`](https://github.com/better-auth/better-auth/commit/92d4e9ece317e33057d50b24cc3843e84f09221f) Merge branch 'canary' into fix/session-skip-invalid-sessions - [`763de01`](https://github.com/better-auth/better-auth/commit/763de0142fae9d0c0f38a5c70fb1bf91abb2ec08) Merge branch 'canary' into fix/session-skip-invalid-sessions - [`a618d07`](https://github.com/better-auth/better-auth/commit/a618d07bff69423903bdc9f01b6b071e2152bfc1) Merge branch 'canary' into fix/session-skip-invalid-sessions - [`b017bb5`](https://github.com/better-auth/better-auth/commit/b017bb5a2cb6f63b7db1d1a9ef121ae79b0b7a3c) fix test and types - [`d7d67c5`](https://github.com/better-auth/better-auth/commit/d7d67c5c750709234486379c20be2b7f43dce747) make lint happy - [`b7e2e0c`](https://github.com/better-auth/better-auth/commit/b7e2e0c0553115b0e63b8353297b5c6ec17c4972) fix test - [`59c199b`](https://github.com/better-auth/better-auth/commit/59c199bf6c56f83166cae7f34a61a34ea2790e79) Merge branch 'canary' into fix/session-skip-invalid-sessions - [`73790ce`](https://github.com/better-auth/better-auth/commit/73790ce2962d1ba502eaf41f7445d9354c7a02cf) fix: use DatabaseSync ### 📊 Changes **4 files changed** (+272 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/db/internal-adapter.test.ts` (+224 -0) 📝 `packages/better-auth/src/db/internal-adapter.ts` (+46 -31) 📝 `packages/better-auth/src/plugins/jwt/jwt.test.ts` (+1 -1) 📝 `packages/scim/src/scim.test.ts` (+1 -1) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Make session listing resilient by skipping invalid or missing sessions in secondary storage. Prevents empty results when one bad session is present. - **Bug Fixes** - listSessions now ignores missing, malformed, or corrupt entries instead of clearing the list. - findSessions now skips invalid or corrupt session data and returns only valid sessions. - Added tests for missing, malformed, corrupt, and all-invalid scenarios. <sup>Written for commit fcec8e49d6659620975bf21dd7a82d386d936723. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:25:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7127
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?