github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #7122] [MERGED] fix(captcha-plugin): export types from the captcha module #7089

New Issue
Closed
opened 2026-03-13 13:23:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:23:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/7122
Author: @sohamingle
Created: 1/4/2026
Status: ✅ Merged
Merged: 1/5/2026
Merged by: @himself65

Base: canary ← Head: fix/captcha-plugin

📝 Commits (1)

  • 6d06e2b fix(captcha): export types from the captcha module

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 packages/better-auth/src/plugins/captcha/index.ts (+2 -0)

📄 Description

Problem

When using the captcha plugin, TypeScript produces the following error:

The inferred type of 'auth' cannot be named without a reference to '@/node_modules/better-auth/dist/plugins/captcha/types.mjs'. This is likely not portable. A type annotation is necessary.

This happens because the CaptchaOptions and related types are used in the public API of the captcha function but aren't exported from the plugin's entry point. TypeScript's declaration emit cannot generate portable .d.ts files when it needs to reference unexported internal types.

Solution

Re-export all types from types.ts in the plugin's index.ts:

export type * from "./types";

This follows the same pattern used by other plugins like two-factor and phone-number.

Testing

Verified the generated dist/plugins/captcha/index.d.mts now exports all types
Confirmed the TypeScript error is resolved when using the captcha plugin in consuming projects

Screenshots

Before

image

After

image

Fixes #7119

Summary by cubic

Re-exported all captcha plugin types from the module entry point to fix TypeScript “inferred type cannot be named” errors and produce portable .d.ts files. Aligns the captcha plugin’s exports with other plugins (two-factor, phone-number).

Written for commit 6d06e2bb1d. Summary will update on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/7122 **Author:** [@sohamingle](https://github.com/sohamingle) **Created:** 1/4/2026 **Status:** ✅ Merged **Merged:** 1/5/2026 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/captcha-plugin` --- ### 📝 Commits (1) - [`6d06e2b`](https://github.com/better-auth/better-auth/commit/6d06e2bb1d2b2d02cf36762045604cfddfd1b7d2) fix(captcha): export types from the captcha module ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/better-auth/src/plugins/captcha/index.ts` (+2 -0) </details> ### 📄 Description ### Problem When using the captcha plugin, TypeScript produces the following error: ``` The inferred type of 'auth' cannot be named without a reference to '@/node_modules/better-auth/dist/plugins/captcha/types.mjs'. This is likely not portable. A type annotation is necessary. ``` This happens because the `CaptchaOptions` and related types are used in the public API of the captcha function but aren't exported from the plugin's entry point. TypeScript's declaration emit cannot generate portable `.d.ts` files when it needs to reference unexported internal types. ### Solution Re-export all types from `types.ts` in the plugin's `index.ts`: ```js export type * from "./types"; ``` This follows the same pattern used by other plugins like `two-factor` and `phone-number`. ### Testing Verified the generated `dist/plugins/captcha/index.d.mts` now exports all types Confirmed the TypeScript error is resolved when using the captcha plugin in consuming projects ### Screenshots #### Before <img width="1018" height="218" alt="image" src="https://github.com/user-attachments/assets/6bdf7096-a8bb-467d-842f-d18435ca1442" /> #### After <img width="660" height="214" alt="image" src="https://github.com/user-attachments/assets/affea2ad-3fd9-4e5e-ae9c-9442b06533e0" /> Fixes #7119 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Re-exported all captcha plugin types from the module entry point to fix TypeScript “inferred type cannot be named” errors and produce portable .d.ts files. Aligns the captcha plugin’s exports with other plugins (two-factor, phone-number). <sup>Written for commit 6d06e2bb1d2b2d02cf36762045604cfddfd1b7d2. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:23:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7089
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?