github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-24 16:11:53 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

Discussion: Exchange default ID generation from random to something like UUID, NanoID, ulid, etc? #707

New Issue
Closed
opened 2026-03-13 08:01:07 -05:00 by GiteaMirror · 6 comments
GiteaMirror commented 2026-03-13 08:01:07 -05:00
Owner
Copy Link

Originally created by @matthiasfeist on GitHub (Feb 19, 2025).

As far as I can see, better-auth currently has its own implementation to create random IDs for DB entries.

I was wondering if it might be good to move towards a different implementation like https://github.com/ulid/javascript for example.

Any opinions? Maybe there was a particular reason why going full custom on the ID generation was chosen?

Originally created by @matthiasfeist on GitHub (Feb 19, 2025). As far as I can see, better-auth currently has its own implementation to create random IDs for DB entries. I was wondering if it might be good to move towards a different implementation like https://github.com/ulid/javascript for example. Any opinions? Maybe there was a particular reason why going full custom on the ID generation was chosen?
GiteaMirror commented 2026-03-13 08:01:08 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Feb 19, 2025):

We previously used nanoid but wanted a more neutral approach to leave the option for users to change it. The current implementation relies on crypto.getRandomValues, but we actually plan to default to db generated IDs in the near future.

@Bekacru commented on GitHub (Feb 19, 2025): We previously used nanoid but wanted a more neutral approach to leave the option for users to change it. The current implementation relies on `crypto.getRandomValues`, but we actually plan to default to db generated IDs in the near future.
GiteaMirror commented 2026-03-13 08:01:08 -05:00
Author
Owner
Copy Link

@matthiasfeist commented on GitHub (Feb 19, 2025):

Ah perfect! DB generated values are ultimately what I would want to use as well.
Is there a branch och something that I could contribute to? Or any other help you might want on this?

@matthiasfeist commented on GitHub (Feb 19, 2025): Ah perfect! DB generated values are ultimately what I would want to use as well. Is there a branch och something that I could contribute to? Or any other help you might want on this?
GiteaMirror commented 2026-03-13 08:01:09 -05:00
Author
Owner
Copy Link

@Bekacru commented on GitHub (Feb 20, 2025):

We already support db generated values by simply setting advanced.generateId to false. The only required change is making generateId: false the default. However, since this is somewhat of a breaking change, we're waiting for the right time to implement it and evaluating whether there are any reasons to keep generated IDs as the default, as we do now.

@Bekacru commented on GitHub (Feb 20, 2025): We already support db generated values by simply setting `advanced.generateId` to `false`. The only required change is making `generateId: false` the default. However, since this is somewhat of a breaking change, we're waiting for the right time to implement it and evaluating whether there are any reasons to keep generated IDs as the default, as we do now.
GiteaMirror commented 2026-03-13 08:01:09 -05:00
Author
Owner
Copy Link

@matthiasfeist commented on GitHub (Feb 20, 2025):

awesome. makes sense

@matthiasfeist commented on GitHub (Feb 20, 2025): awesome. makes sense
GiteaMirror commented 2026-03-13 08:01:10 -05:00
Author
Owner
Copy Link

@theinfinit commented on GitHub (Feb 24, 2025):

We already support db generated values by simply setting advanced.generateId to false.

Just tried it out. Changing generateId to false results in:

  • a NOT NULL constraint failed errors for existing and new DBs,
  • users being created without id, instead of being auto-incremented by DB (maybe ID it's explicitly set to NULL in the query?).
    • This results in error: Failed to create user SqliteError: NOT NULL constraint failed: user.id

Tested with 1.2.0-beta.16 npm package.

@theinfinit commented on GitHub (Feb 24, 2025): > We already support db generated values by simply setting `advanced.generateId` to `false`. Just tried it out. Changing `generateId` to `false` results in: - a `NOT NULL constraint failed` errors for existing and new DBs, - users being created without `id`, instead of being auto-incremented by DB (maybe ID it's explicitly set to NULL in the query?). - This results in error: `Failed to create user SqliteError: NOT NULL constraint failed: user.id` Tested with `1.2.0-beta.16` npm package.
GiteaMirror commented 2026-03-13 08:01:10 -05:00
Author
Owner
Copy Link

@dosubot[bot] commented on GitHub (Jun 14, 2025):

Hi, @matthiasfeist. I'm Dosu, and I'm helping the better-auth team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • The issue proposes changing the default ID generation method to standardized libraries like UUID, NanoID, or ULID.
  • Current implementation uses crypto.getRandomValues, with an option to use database-generated IDs by setting advanced.generateId to false.
  • User theinfinit reported errors when setting generateId to false, such as NOT NULL constraint failed and users being created without IDs in version 1.2.0-beta.16.

Next Steps:

  • Please confirm if this issue is still relevant to the latest version of the better-auth repository. If so, you can keep the discussion open by commenting on this issue.
  • Otherwise, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot[bot] commented on GitHub (Jun 14, 2025): Hi, @matthiasfeist. I'm [Dosu](https://dosu.dev), and I'm helping the better-auth team manage their backlog. I'm marking this issue as stale. **Issue Summary:** - The issue proposes changing the default ID generation method to standardized libraries like UUID, NanoID, or ULID. - Current implementation uses `crypto.getRandomValues`, with an option to use database-generated IDs by setting `advanced.generateId` to `false`. - User theinfinit reported errors when setting `generateId` to `false`, such as `NOT NULL constraint failed` and users being created without IDs in version `1.2.0-beta.16`. **Next Steps:** - Please confirm if this issue is still relevant to the latest version of the better-auth repository. If so, you can keep the discussion open by commenting on this issue. - Otherwise, this issue will be automatically closed in 7 days. Thank you for your understanding and contribution!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#707
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?