github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 07:18:56 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6996] [MERGED] test(oauth-provider): correct failing test #7014

New Issue
Closed
opened 2026-03-13 13:21:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:21:10 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6996
Author: @bytaesu
Created: 12/25/2025
Status: ✅ Merged
Merged: 12/25/2025
Merged by: @Bekacru

Base: canary ← Head: 2025-12-26/test/oauth-provider-metadata

📝 Commits (2)

  • d53c17b test: correct test code
  • 590be88 Update packages/oauth-provider/src/metadata.test.ts

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 packages/oauth-provider/src/metadata.test.ts (+1 -3)

📄 Description

test

Summary by cubic

Fix oauth-provider metadata test by asserting that getOpenIdConfig rejects with APIError (class) instead of a specific NOT_FOUND instance. This matches current error handling and prevents false failures when OpenID config is missing.

Written for commit 590be88e12. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6996 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 12/25/2025 **Status:** ✅ Merged **Merged:** 12/25/2025 **Merged by:** [@Bekacru](https://github.com/Bekacru) **Base:** `canary` ← **Head:** `2025-12-26/test/oauth-provider-metadata` --- ### 📝 Commits (2) - [`d53c17b`](https://github.com/better-auth/better-auth/commit/d53c17bd141d2ed9b1e9fe80d9c703234a58b093) test: correct test code - [`590be88`](https://github.com/better-auth/better-auth/commit/590be88e12f6fcbda8b1853b47e5949d9c80cc6a) Update packages/oauth-provider/src/metadata.test.ts ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/oauth-provider/src/metadata.test.ts` (+1 -3) </details> ### 📄 Description <img width="992" height="433" alt="test" src="https://github.com/user-attachments/assets/4e9e32eb-2be6-4272-a8d4-324533316fb7" /> <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Fix oauth-provider metadata test by asserting that getOpenIdConfig rejects with APIError (class) instead of a specific NOT_FOUND instance. This matches current error handling and prevents false failures when OpenID config is missing. <sup>Written for commit 590be88e12f6fcbda8b1853b47e5949d9c80cc6a. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:21:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#7014
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?