github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-22 22:32:01 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6939] [MERGED] fix(expo): add missing matcher paths #6978

New Issue
Closed
opened 2026-03-13 13:19:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:19:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6939
Author: @bytaesu
Created: 12/22/2025
Status: ✅ Merged
Merged: 12/23/2025
Merged by: @himself65

Base: canary ← Head: 2025-12-23/fix/expo-session-deep-link

📝 Commits (4)

  • 58ef571 fix: add missing matcher paths
  • 7022350 test: add cases for magic-link and verify-email
  • c7d5ce3 test: migrate from testUtil to getTestInstance
  • 9eaff95 chore(expo): remove unused better-sqlite3 dev deps

📊 Changes

4 files changed (+236 additions, -107 deletions)

View changed files

📝 packages/expo/package.json (+0 -2)
📝 packages/expo/src/index.ts (+3 -1)
📝 packages/expo/test/expo.test.ts (+233 -98)
📝 pnpm-lock.yaml (+0 -6)

📄 Description

  • Add /magic-link/verify and /verify-email paths to matcher
  • Migrate test code to use getTestInstance

Closes https://github.com/better-auth/better-auth/issues/6936

Summary by cubic

Add missing matcher paths in the Expo auth middleware for /magic-link/verify and /verify-email so deep-link verification works and session cookies are injected on mobile.

  • Bug Fixes

    • Add /magic-link/verify and /verify-email to the middleware matcher.
    • Ensure deep-link redirects include a session cookie for magic link and email verification flows.

  • Refactors

    • Migrate tests to getTestInstance and add cases for magic-link and verify-email deep-link flows.
    • Remove unused better-sqlite3 dev dependencies.

Written for commit 9eaff95d5f. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6939 **Author:** [@bytaesu](https://github.com/bytaesu) **Created:** 12/22/2025 **Status:** ✅ Merged **Merged:** 12/23/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `2025-12-23/fix/expo-session-deep-link` --- ### 📝 Commits (4) - [`58ef571`](https://github.com/better-auth/better-auth/commit/58ef5714b7005a767a5967dcf936ddc4bcaff561) fix: add missing matcher paths - [`7022350`](https://github.com/better-auth/better-auth/commit/7022350ab0090a3a10d283228febc0bd9f931241) test: add cases for magic-link and verify-email - [`c7d5ce3`](https://github.com/better-auth/better-auth/commit/c7d5ce3dc110a740b821786730956a59721b97fc) test: migrate from testUtil to getTestInstance - [`9eaff95`](https://github.com/better-auth/better-auth/commit/9eaff95d5f1c359d5f5f00259b7fce0eb51e5be6) chore(expo): remove unused better-sqlite3 dev deps ### 📊 Changes **4 files changed** (+236 additions, -107 deletions) <details> <summary>View changed files</summary> 📝 `packages/expo/package.json` (+0 -2) 📝 `packages/expo/src/index.ts` (+3 -1) 📝 `packages/expo/test/expo.test.ts` (+233 -98) 📝 `pnpm-lock.yaml` (+0 -6) </details> ### 📄 Description - Add `/magic-link/verify` and `/verify-email` paths to matcher - Migrate test code to use `getTestInstance` Closes https://github.com/better-auth/better-auth/issues/6936 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Add missing matcher paths in the Expo auth middleware for /magic-link/verify and /verify-email so deep-link verification works and session cookies are injected on mobile. - **Bug Fixes** - Add /magic-link/verify and /verify-email to the middleware matcher. - Ensure deep-link redirects include a session cookie for magic link and email verification flows. - **Refactors** - Migrate tests to getTestInstance and add cases for magic-link and verify-email deep-link flows. - Remove unused better-sqlite3 dev dependencies. <sup>Written for commit 9eaff95d5f1c359d5f5f00259b7fce0eb51e5be6. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:19:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6978
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?