github-starred/better-auth
2
0
Fork 0
mirror of https://github.com/better-auth/better-auth.git synced 2026-05-23 15:42:09 -05:00
Code Issues 2.5k Packages Projects Releases 112 Wiki Activity

[PR #6839] [MERGED] chore(sso): clean up SAML test suite #6914

New Issue
Closed
opened 2026-03-13 13:16:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-13 13:16:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/better-auth/better-auth/pull/6839
Author: @Paola3stefania
Created: 12/17/2025
Status: ✅ Merged
Merged: 12/23/2025
Merged by: @himself65

Base: canary ← Head: fix/saml-test

📝 Commits (9)

📊 Changes

1 file changed (+13 additions, -5 deletions)

View changed files

📝 packages/sso/src/routes/sso.ts (+13 -5)

📄 Description

Summary by cubic

Cleaned up the SAML SSO test suite and tightened SSO provider types. This removes type errors and stabilizes the tests.

  • Refactors
    • Added SSOProviderResponse and narrowed SSOProviderReturn to return parsed oidcConfig/samlConfig with explicit fields.
    • Refactored registerSSOProvider to build a typed result before returning via ctx.json.
    • Simplified customFetchImpl usage in tests for consistency.

Written for commit 224f2c6f0b. Summary will update automatically on new commits.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/better-auth/better-auth/pull/6839 **Author:** [@Paola3stefania](https://github.com/Paola3stefania) **Created:** 12/17/2025 **Status:** ✅ Merged **Merged:** 12/23/2025 **Merged by:** [@himself65](https://github.com/himself65) **Base:** `canary` ← **Head:** `fix/saml-test` --- ### 📝 Commits (9) - [`69a6a5d`](https://github.com/better-auth/better-auth/commit/69a6a5d9ac7c378a92e9fec9f5b7c197ae310ee8) fix types - [`f118640`](https://github.com/better-auth/better-auth/commit/f11864090a29e91186be1aa99204fff50140f966) fix cleanup - [`098e199`](https://github.com/better-auth/better-auth/commit/098e19939e1bafb7f99edbf24bfa1edf93dd07fc) fix: sso provider types - [`fddb631`](https://github.com/better-auth/better-auth/commit/fddb631d9aef904113e0bca55377d99ba5322c3d) make lint happy - [`1ec41da`](https://github.com/better-auth/better-auth/commit/1ec41da1793e475d9bcd9e25bc8000d03f560e45) Merge branch 'canary' into fix/saml-test - [`7221335`](https://github.com/better-auth/better-auth/commit/7221335d0bd4ba2b8f412b47acf62680cc5739e9) fix: types - [`9910d2b`](https://github.com/better-auth/better-auth/commit/9910d2becfb717aff80f0e20717181fb8cd637e3) Merge branch 'fix/saml-test' of https://github.com/better-auth/better-auth into fix/saml-test - [`052e28c`](https://github.com/better-auth/better-auth/commit/052e28c9b2af9e762429b739ce33e57ceb9a169a) make lint happy - [`224f2c6`](https://github.com/better-auth/better-auth/commit/224f2c6f0b1e3b390a3c65fb33560fe6d9b93dad) Merge branch 'canary' into fix/saml-test ### 📊 Changes **1 file changed** (+13 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/sso/src/routes/sso.ts` (+13 -5) </details> ### 📄 Description <!-- This is an auto-generated description by cubic. --> ## Summary by cubic Cleaned up the SAML SSO test suite and tightened SSO provider types. This removes type errors and stabilizes the tests. - **Refactors** - Added SSOProviderResponse and narrowed SSOProviderReturn to return parsed oidcConfig/samlConfig with explicit fields. - Refactored registerSSOProvider to build a typed result before returning via ctx.json. - Simplified customFetchImpl usage in tests for consistency. <sup>Written for commit 224f2c6f0b1e3b390a3c65fb33560fe6d9b93dad. Summary will update automatically on new commits.</sup> <!-- End of auto-generated description by cubic. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-13 13:16:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
adapter
astro
awaiting external contributor
blocked
breaking
breaking change
bug
c-devops
core
credentials
database
dependencies
devops
devtools
docs
documentation
duplicate
elysia
enhancement
enterprise
expo
express
fastify
good first issue
help wanted
hono
identity
infra
integration
invalid
javascript
locked
maintenance
need-more-information
needs: info
needs: repro
nextjs
nuxt
oauth
organization
P0
payments
perf
platform
plugin
pull-request
Mirrored from GitHub Pull Request
 question
ready
regression
remix
security
social-provider
solid
stale
svelte
tanstack-start
tracking
version-bump
vue
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/better-auth#6914
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?